Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

fix(command generate): fix error when analyzing database on mssql with case sensitive collation #432

Merged
merged 2 commits into from
May 15, 2020
Merged

fix(command generate): fix error when analyzing database on mssql with case sensitive collation #432

merged 2 commits into from
May 15, 2020

Conversation

arnaud-moncel
Copy link
Member

Need to wait a new release of Sequelize to fix queryInterface.describeTable function.

Clickup card

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@arnaud-moncel arnaud-moncel requested a review from DrRaider May 14, 2020 15:09
@arnaud-moncel arnaud-moncel changed the title [WIP] fix: error when analyzing database on mssql with case sensitive collation (#4ur8wt) fix: error when analyzing database on mssql with case sensitive collation May 14, 2020
@arnaud-moncel arnaud-moncel changed the title fix: error when analyzing database on mssql with case sensitive collation fix: fix error when analyzing database on mssql with case sensitive collation May 15, 2020
DrRaider
DrRaider approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@DrRaider DrRaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the suggestion and it's all good, don't forget to notify the impacted customer, he was waiting for this :)

@DrRaider DrRaider assigned arnaud-moncel and unassigned DrRaider May 15, 2020
@arnaud-moncel arnaud-moncel changed the title fix: fix error when analyzing database on mssql with case sensitive collation fix(command generate): fix error when analyzing database on mssql with case sensitive collation May 15, 2020
@arnaud-moncel arnaud-moncel force-pushed the fix/onboarding-mssql-cs-collation branch from ce75212 to 5821847 Compare May 15, 2020 10:18
@arnaud-moncel arnaud-moncel merged commit 0873fd3 into master May 15, 2020
@arnaud-moncel arnaud-moncel deleted the fix/onboarding-mssql-cs-collation branch May 15, 2020 10:28
arnaudbesnier pushed a commit that referenced this pull request May 15, 2020
@arnaud-moncel @arnaudbesnier
fix(command generate): fix an error on mssql database analysis with c…
6520ab1 
…ase sensitive collation (#432)
forest-bot added a commit that referenced this pull request May 15, 2020
@forest-bot
chore(release): 3.5.6 [skip ci]
e0af2db 
## [3.5.6](v3.5.5...v3.5.6) (2020-05-15)

### Bug Fixes

* **command generate:** fix an error on mssql database analysis with case sensitive collation ([#432](#432)) ([6520ab1](6520ab1))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrRaider DrRaider DrRaider approved these changes

Assignees

@arnaud-moncel arnaud-moncel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-moncel @DrRaider