Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

fix(security): patch newly detected vulnerabilities #431

Merged
merged 1 commit into from
May 11, 2020

Conversation

arnaudbesnier
Copy link
Contributor

@arnaudbesnier arnaudbesnier commented May 11, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@@ -59,7 +59,7 @@
"eslint-plugin-sonarjs": "0.5.0",
"git-hooks": "1.1.10",
"husky": "4.2.3",
"jest": "24.9.0",
"jest": "26.0.1",
Copy link
Contributor Author

@arnaudbesnier arnaudbesnier May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev dependency update + All tests pass = we are safe here

@@ -29,7 +29,7 @@
"chalk": "^1.1.3",
"commander": "^2.9.0",
"dotenv": "^6.0.0",
"handlebars": "4.5.2",
"handlebars": "4.7.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor version increment (theoretically safe) + 80% coverage + All test pass + read the changelog = confident here

integrity sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=

minimist@^1.2.5:
minimist@^1.1.1, minimist@^1.2.0, minimist@^1.2.5:
Copy link
Contributor Author

@arnaudbesnier arnaudbesnier May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimist upgrade to remove vulnerabilities

version "7.1.0"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.0.tgz#949d36f2c292535da602283586c2477c57eb2d6c"
integrity sha512-kL5CuoXA/dgxlBbVrflsflzQ3PAas7RYZB52NOm/6839iVYJgKMJ3cQJD+t2i5+qFa8h3MDpEOJiS64E8JLnSQ==
acorn@^7.1.0, acorn@^7.1.1:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acorn upgrade to remove vulnerabilities

@@ -4842,9 +5168,9 @@ kind-of@^5.0.0:
integrity sha512-NGEErnH6F2vUuXDh+OlbcKW7/wOcfdRHaZ7VWtqCztfHri/++YKmP51OdWeGPuqCOba6kk2OTe5d02VmTB80Pw==

kind-of@^6.0.0, kind-of@^6.0.2:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind-of upgrade to remove vulnerabilities

@arnaudbesnier arnaudbesnier merged commit 724a6a9 into master May 11, 2020
@arnaudbesnier arnaudbesnier deleted the security/patch-vulnerabilities branch May 11, 2020 17:23
forest-bot added a commit that referenced this pull request May 11, 2020
## [3.5.4](v3.5.3...v3.5.4) (2020-05-11)

### Bug Fixes

* **security:** patch newly detected vulnerabilities ([#431](#431)) ([724a6a9](724a6a9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 3.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants