Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation revamp #187

Open
2 of 3 tasks
theabhirath opened this issue Jul 26, 2022 · 4 comments
Open
2 of 3 tasks

Documentation revamp #187

theabhirath opened this issue Jul 26, 2022 · 4 comments
Labels
documentation Documentation

Comments

@theabhirath
Copy link
Member

theabhirath commented Jul 26, 2022

The current documentation format is a little weird and Publish exposes a lot of private functions in the API reference as well. There are several steps that need to be decided on:

  • Migration to Documenter.jl or Pollen.jl. Publish CI times have also been bad, so this should be an easy move. The question is which of Documenter or Pollen would be better suited.
  • Polishing up the documentation for the Layers module, and exposing the API reference for it in a separate, visible place. This includes custom Layers options like AdaptiveMeanMaxPool being added in Overhaul of ResNet API #174, which we could even export from Metalhead itself for ease of use
  • Use the GitHub Wiki feature to Create a comprehensive developer documentation inside of the main documentation. This will include stuff like the absolute lowest level API of models (such as the ResNet one from Overhaul of ResNet API #174), as well as other helpful instructions like the code style (SciML), which will allow new contributors to understand the codebase better before they dive in.

cc @darsnack @ToucheSir @lorenzoh for the Documenter/Pollen migration, which is probably the highest priority on this list

@theabhirath theabhirath added the documentation Documentation label Jul 26, 2022
@darsnack
Copy link
Member

I would prefer Pollen.jl because it accepts more formats including notebooks.

For the last point, I would prefer to have a developer section directly in the docs (where contributing already lives) instead of enabling the wiki feature. My previous experience with GitHub wikis has been poor, and it does not make sense to split the documentation in two places.

@theabhirath
Copy link
Member Author

One of the main questions I have regarding Pollen is if there is support for documenting multiple versions of the same package? This is something I suspect we will need quite a bit when 0.8 lands, since that will be massively breaking.

@theabhirath theabhirath added this to the 0.8 milestone Jul 26, 2022
@lorenzoh
Copy link
Member

Support in Pollen.jl for documenting multiple versions kinda works but is not great rn, i.e. no GitHub Action when a new version is tagged, no version picker in the frontend. Improving this is something I have been working on, but I will have little bandwidth to continue that work until the beginning of September.
In parallel, I have been working on making it fully compatible with Documenter.jl syntax.
So, I wouldn't propose moving to Pollen.jl right now, but we could either postpone a move or move to Documenter.jl with the option of easily switching to Pollen.jl later once that is possible.

@CarloLucibello
Copy link
Member

This issue us is part of the v0.8 milestone. What needs to be done to close it?

@CarloLucibello CarloLucibello removed this from the 0.8 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

No branches or pull requests

4 participants