Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidSynth ignores LSB in Pitch Bend Range #1357

Closed
spessasus opened this issue Jul 24, 2024 · 2 comments · Fixed by #1358
Closed

FluidSynth ignores LSB in Pitch Bend Range #1357

spessasus opened this issue Jul 24, 2024 · 2 comments · Fixed by #1358
Labels
Milestone

Comments

@spessasus
Copy link
Contributor

FluidSynth version

Execute fluidsynth --version and provide the output.

FluidSynth runtime version 2.3.5
Copyright (C) 2000-2024 Peter Hanappe and others.
Distributed under the LGPL license.
SoundFont(R) is a registered trademark of Creative Technology Ltd.

FluidSynth executable version 2.3.5
Sample type=double

Describe the bug

Provide a clear and concise description of the current situation, e.g. how the bug manifests.

Fluidsynth only allows to specify the pitch bend range in semitones, ignoring the cent tuning via data entry.
Test MIDI file The second note in this file doesn't change its pitch as the bend range is set to 50 cents.

Expected behavior

Provide a clear and concise description of what you expected to happen.

The second note should have a noticeable pitch change when the range is set to 50 cents.

Steps to reproduce

Please explain the steps required to duplicate the issue, esp. if you are able to provide a sample application. E.g. how to start fluidsynth, what shell commands to enter, what midi events to send, etc.

  1. Get the file
  2. fluidsynth microsoft_gm.sf2 test-rpn-00-00-pitch-bend-range.mid
  3. No audible pitch change on the second note

Additional context

Soundfont spec doesn't say anything about the way pitch bend range should be stored so simply doing

float pitchBendRange = semitones + (cents / 100);

should easily fix the problem without further modifications.

@spessasus spessasus added the bug label Jul 24, 2024
@derselbst
Copy link
Member

You're welcome to file a PR:

/* FIXME - Handle LSB? (Fine bend range in cents) */

@spessasus
Copy link
Contributor Author

Alright, I created a pull request, I hope it looks good!

@derselbst derselbst added this to the 2.3 milestone Jul 27, 2024
@derselbst derselbst linked a pull request Jul 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants