Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks docs.rs build #79

Closed
ctron opened this issue Oct 15, 2020 · 4 comments
Closed

Breaks docs.rs build #79

ctron opened this issue Oct 15, 2020 · 4 comments

Comments

@ctron
Copy link

ctron commented Oct 15, 2020

It looks like the upgrade from Rust nightly 1.48 to 1.49 (which docs.rs uses) breaks the docs build now. To my understanding, this comes from embedded-time:

error[E0284]: type annotations needed: cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`
   --> /home/jreimann/.cargo/registry/src/github.com-1ecc6299db9ec823/embedded-time-0.10.0/./src/instant.rs:182:66
    |
182 |         if add_ticks <= (<Clock::T as num::Bounded>::max_value() / 2.into()) {
    |                                                                  ^ cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`

error[E0284]: type annotations needed: cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`
   --> /home/jreimann/.cargo/registry/src/github.com-1ecc6299db9ec823/embedded-time-0.10.0/./src/instant.rs:220:66
    |
220 |         if sub_ticks <= (<Clock::T as num::Bounded>::max_value() / 2.into()) {
    |                                                                  ^ cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`

error[E0284]: type annotations needed: cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`
   --> /home/jreimann/.cargo/registry/src/github.com-1ecc6299db9ec823/embedded-time-0.10.0/./src/instant.rs:273:60
    |
273 |             .cmp(&(<Clock::T as num::Bounded>::max_value() / 2.into()))
    |                                                            ^ cannot satisfy `<<Clock as Clock>::T as Div<_>>::Output == <Clock as Clock>::T`

@PTaylor-us
Copy link
Member

Thank you for reporting this. #78 was merged to master as a fix, but I haven't released a new version yet.

@hannobraun
Copy link
Contributor

@PTaylor-us Would you consider releasing a new version some time soon? I have some new libraries that have no working documentation on docs.rs, and other crates that I couldn't release right now if I wanted (as to not break the documentation).

This also causes failure on my CI builds for the nightly channel, and I assume it's going to work its way up to the beta and stable channels soon.

Thank you for your work on this library! I think it's great and fills an important need.

@PTaylor-us
Copy link
Member

@hannobraun Sorry for the delay. I will plan to create a new release in the next day or two.

@hannobraun
Copy link
Contributor

Thank you, and no need to apologize!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants