Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Support for pass(1) as credential storage #33

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Ma27
Copy link
Contributor

@Ma27 Ma27 commented Jul 10, 2022

pass(1)[1] is a small CLI-based password manager. When passing
--pass-path edu/kit/uXXXX to KIT-ILIAS-Downloader, it now attempts
to retrieve the password from pass(1).

It is assumed that pass(1) is available in the $PATH of the process. If
that's not the case, it errors out with an error like this:

Error: credentials input failed

Caused by:
    pass not found in $PATH!

It's also taken care of the case where the value --pass-path is not
present in the store, the error will look like this:

Error: credentials input failed

Caused by:
    `pass` failed with non-zero exit code 1: Error: edu/kit/uXXXX is not in the password store.

Closes #32

[1] https://www.passwordstore.org/

`pass(1)`[1] is a small CLI-based password manager. When passing
`--pass-path edu/kit/uXXXX` to `KIT-ILIAS-Downloader`, it now attempts
to retrieve the password from `pass(1)`.

It is assumed that `pass(1)` is available in the `$PATH` of the process. If
that's not the case, it errors out with an error like this:

    Error: credentials input failed

    Caused by:
        pass not found in $PATH!

It's also taken care of the case where the value `--pass-path` is not
present in the store, the error will look like this:

    Error: credentials input failed

    Caused by:
        `pass` failed with non-zero exit code 1: Error: edu/kit/uXXXX is not in the password store.

Closes FliegendeWurst#32

[1] https://www.passwordstore.org/
@FliegendeWurst FliegendeWurst added the enhancement New feature or request label Jul 11, 2022
Copy link
Owner

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

I just tested the new option, everything works as expected.

@FliegendeWurst FliegendeWurst merged commit 38ce269 into FliegendeWurst:master Jul 11, 2022
@Ma27 Ma27 deleted the pass-integration branch July 11, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pass backend as alternative to the Linux keyring to retrieve the shibboleth credentials
2 participants