Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and use Fladle plugin together with Flank #1804

Closed
piotradamczyk5 opened this issue Apr 13, 2021 · 3 comments
Closed

Build and use Fladle plugin together with Flank #1804

piotradamczyk5 opened this issue Apr 13, 2021 · 3 comments

Comments

@piotradamczyk5
Copy link
Contributor

Author the user story for this feature

As a Developer, I want to use Fladle together with Flank using composite build so I can develop plugin even better.

Describe the solution

  1. Setup Fladle as git submodule
  2. Use a composite build to substitute the flank dependency.
  3. Add an integration test for the fladle plugin in the flank project. This is a good idea whether or not we are going to integrate both projects to prevent regressions.

Resources

@bootstraponline
Copy link
Contributor

do we need the submodule for a composite build?

@piotradamczyk5
Copy link
Contributor Author

We need to substitute in somehow with providing path to module and to make it more automated submodules seems to be good solution

@zuziaka
Copy link
Contributor

zuziaka commented May 24, 2021

Closing this ticket as #1963 #1964 were created.

@zuziaka zuziaka closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants