Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing Metadata section when creating or features deletes all unsaved changes #4305

Open
1 of 4 tasks
rolodato opened this issue Jul 8, 2024 · 0 comments
Open
1 of 4 tasks
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

rolodato commented Jul 8, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

The Metadata section shown when editing or creating features is collapsible. If changes are made to fields in that section and it's collapsed without saving changes, those changes are permanently lost.

Steps To Reproduce

  1. Create a metadata field for features
  2. Create a new feature and open the Metadata section
  3. Type something into a metadata field
  4. Collapse the Metadata section

Your changes are now gone.

Expected behavior

Never delete unsaved user data when editing custom fields.

My strong preference would be to remove the collapsible section altogether, and don't show it if no metadata fields are configured. Metadata fields should have the same prominence/visibility as regular fields - we can't assume anything about how important they should be to customers.

Hiding required fields behind a collapsible section or a different tab and not highlighting them in any way is also a surefire way to frustrate users.

Screenshots

metadata.unsaved.collapse.mov
@rolodato rolodato added the bug Something isn't working label Jul 8, 2024
@novakzaballa novakzaballa linked a pull request Jul 11, 2024 that will close this issue
5 tasks
@novakzaballa novakzaballa removed a link to a pull request Jul 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants