Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not providing required environment fields causes environment saving to fail without errors #4302

Open
1 of 4 tasks
rolodato opened this issue Jul 8, 2024 · 0 comments
Open
1 of 4 tasks
Assignees
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Contributor

rolodato commented Jul 8, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

See reproduction steps below

Steps To Reproduce

  1. Create a required field for environments
  2. Try to make any change to a preexisting environment, such as changing the name/banner or enabling/disabling change requests

No errors are shown and the changes are not saved.

Expected behavior

Several possible solutions here:

  1. Show an error message when trying to save an environment without providing any required metadata fields
  2. Do not allow defining required environment fields - environments are created very infrequently so giving users the option to enforce this might not be useful
  3. Ignore errors about missing required environment fields when updating environments if the required fields were originally not present. This forces new environments to be created with all required fields, while still allowing users to make changes to their preexisting environments without needing to provide required fields.

I would strongly prefer option 3 because of how infrequently environments are created and modified. Preventing users from doing anything with their existing environments seems too hard of a blocker, especially considering that virtually all users that create metadata fields will have preexisting environments (the ones created by default by Flagsmith).

Screenshots

No response

@rolodato rolodato added the bug Something isn't working label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants