Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tag-based permission only validate some views #4287

Open
2 of 4 tasks
novakzaballa opened this issue Jul 5, 2024 · 2 comments
Open
2 of 4 tasks

The tag-based permission only validate some views #4287

novakzaballa opened this issue Jul 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@novakzaballa
Copy link
Contributor

novakzaballa commented Jul 5, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

The tag-based permission with UPDATE_FEATURE_STATE only validates FeatureStatePermissions and not EnvironmentFeatureStatePermissions.
This last one is used when updating a feature state value from the feature modal.

Steps To Reproduce

  1. Create a role with View Project, View environment, and update feature state, add a tag, and assign it to test user
  2. Log in with the test user
  3. Go to the project -> environment that you have permission to access.
  4. Select a feature and update the feature state
  5. The feature state was updated successfully (This is an error)

Expected behavior

If the feature does not have the same tag, the feature state value should not be updated.

Screenshots

No response

CC: @matthewelwell @gagantrivedi @kyle-ssg

@matthewelwell
Copy link
Contributor

@gagantrivedi can you confirm if this is expected behaviour or not?

@gagantrivedi
Copy link
Member

gagantrivedi commented Jul 9, 2024

@gagantrivedi can you confirm if this is expected behaviour or not?

Looks like a legit issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants