Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling for Unregistered Account Sign-In #4270

Open
2 of 4 tasks
sumtzehern opened this issue Jul 1, 2024 · 3 comments
Open
2 of 4 tasks

Improve Error Handling for Unregistered Account Sign-In #4270

sumtzehern opened this issue Jul 1, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sumtzehern
Copy link
Contributor

sumtzehern commented Jul 1, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • SaaS at flagsmith.com
  • Self Hosted with Kubernetes
  • Some other way (add details in description below)

Describe the bug

Currently, when a user attempts to sign in with an unregistered account, the application displays a generic "Server Error (500)" message in the toast notification. This error message is not user-friendly and does not provide helpful information to the user.

Steps To Reproduce

  1. Go to the sign-in page.
  2. Enter an invalid email and password (e.g. foo / bar).
  3. Submit the sign-in form.

Expected behavior

The application should display a toast notification with a clear and user-friendly error message, such as "Username provided is not a valid email."

Screenshots

Screenshot 2024-07-01 at 6 06 31 PM
@sumtzehern sumtzehern added the bug Something isn't working label Jul 1, 2024
@matthewelwell
Copy link
Contributor

@sumtzehern I am unable to reproduce this behaviour, please can you provide further steps to reproduce this.

image

@sumtzehern
Copy link
Contributor Author

This would happen when a user type in a Unregistered username, email would work fine.

image

@sumtzehern sumtzehern reopened this Jul 8, 2024
@matthewelwell
Copy link
Contributor

Ok, thanks - I've updated the description of the issue with further clarifications regarding this behaviour. If you'd like to submit a PR for this, please feel free to do so. Otherwise, since this isn't a valid use case (we don't support non-email address usernames), this will likely not be prioritised.

@matthewelwell matthewelwell added the good first issue Good for newcomers label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants