From 48e697c49dd77967293525b230fea6292a69dfc0 Mon Sep 17 00:00:00 2001 From: Alexander Miehe Date: Thu, 2 Jan 2020 12:56:27 +0100 Subject: [PATCH 1/4] add missing raw_message_delivery typ --- variables.tf | 1 + 1 file changed, 1 insertion(+) diff --git a/variables.tf b/variables.tf index ca50778..b374544 100644 --- a/variables.tf +++ b/variables.tf @@ -5,6 +5,7 @@ variable "sns_topic_subscriptions" { protocol = string endpoint = string endpoint_auto_confirms = bool + raw_message_delivery = bool })) default = [] description = "SNS Subscriptions" From 7bfefe7bea871be195433e2781ea851f3d129827 Mon Sep 17 00:00:00 2001 From: Alexander Miehe Date: Thu, 2 Jan 2020 13:14:21 +0100 Subject: [PATCH 2/4] * add raw_message_delivery to example --- examples/complete/main.tf | 2 ++ main.tf | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/complete/main.tf b/examples/complete/main.tf index 848b4fd..3548683 100644 --- a/examples/complete/main.tf +++ b/examples/complete/main.tf @@ -10,6 +10,7 @@ locals { protocol = "lambda" endpoint = "some_arn" endpoint_auto_confirms = true + raw_message_delivery = true }, { name = "random_named2" @@ -17,6 +18,7 @@ locals { protocol = "lambda" endpoint = "some_arn2" endpoint_auto_confirms = false + raw_message_delivery = false }, ] } diff --git a/main.tf b/main.tf index d33a285..10b8679 100644 --- a/main.tf +++ b/main.tf @@ -4,5 +4,5 @@ resource "aws_sns_topic_subscription" "this" { protocol = each.value.protocol endpoint = each.value.endpoint endpoint_auto_confirms = each.value.endpoint_auto_confirms - raw_message_delivery = lookup(each.value, "raw_message_delivery", null) + raw_message_delivery = each.value.raw_message_delivery } From 86879811f971a5f97b9f69f07a8a802f179a688e Mon Sep 17 00:00:00 2001 From: Alexander Miehe Date: Thu, 2 Jan 2020 13:33:30 +0100 Subject: [PATCH 3/4] * add filter policy support --- examples/complete/main.tf | 2 ++ main.tf | 1 + variables.tf | 1 + 3 files changed, 4 insertions(+) diff --git a/examples/complete/main.tf b/examples/complete/main.tf index 3548683..db7b557 100644 --- a/examples/complete/main.tf +++ b/examples/complete/main.tf @@ -11,6 +11,7 @@ locals { endpoint = "some_arn" endpoint_auto_confirms = true raw_message_delivery = true + filter_policy = "" }, { name = "random_named2" @@ -19,6 +20,7 @@ locals { endpoint = "some_arn2" endpoint_auto_confirms = false raw_message_delivery = false + filter_policy = "{\"LiteMessageType\":[\"OrderCreated\"]}" }, ] } diff --git a/main.tf b/main.tf index 10b8679..b872239 100644 --- a/main.tf +++ b/main.tf @@ -5,4 +5,5 @@ resource "aws_sns_topic_subscription" "this" { endpoint = each.value.endpoint endpoint_auto_confirms = each.value.endpoint_auto_confirms raw_message_delivery = each.value.raw_message_delivery + filter_policy = each.value.filter_policy } diff --git a/variables.tf b/variables.tf index b374544..1eeb744 100644 --- a/variables.tf +++ b/variables.tf @@ -6,6 +6,7 @@ variable "sns_topic_subscriptions" { endpoint = string endpoint_auto_confirms = bool raw_message_delivery = bool + filter_policy = string })) default = [] description = "SNS Subscriptions" From 12f9b13a2bcdd3f76b29f6a4dd0ee4ae898a500e Mon Sep 17 00:00:00 2001 From: Alexander Miehe Date: Thu, 2 Jan 2020 13:34:08 +0100 Subject: [PATCH 4/4] * add filter policy support --- examples/complete/main.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/complete/main.tf b/examples/complete/main.tf index db7b557..6502b4f 100644 --- a/examples/complete/main.tf +++ b/examples/complete/main.tf @@ -11,7 +11,7 @@ locals { endpoint = "some_arn" endpoint_auto_confirms = true raw_message_delivery = true - filter_policy = "" + filter_policy = "" }, { name = "random_named2" @@ -20,7 +20,7 @@ locals { endpoint = "some_arn2" endpoint_auto_confirms = false raw_message_delivery = false - filter_policy = "{\"LiteMessageType\":[\"OrderCreated\"]}" + filter_policy = "{\"LiteMessageType\":[\"OrderCreated\"]}" }, ] }