Allow IEnumerable instead of HashSet in server broadcasting + improve performance in SceneManager #433
Closed
LambdaTheDev
started this conversation in
Feature Request
Replies: 2 comments
-
Edited: I can however optimize the SceneManager methods and a few more in there. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Improved where applicable. Available in 3.10.8R |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In
ServerManager.Broadcast(connections, ...);
instead ofHashSet<NetworkConnection>
useIEnumerable<NetworkConnection>
since it's more general & does not break anything.Plus, in SceneManager, like 1779, you literally allocate an array just to iterate through it. In
RebuildObservers(...)
method also allowIEnumerable<NetworkObject>
and in line mentioned above remove.ToArray()
call.Beta Was this translation helpful? Give feedback.
All reactions