Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does MakeElementStack() have to use ToTypedElementLegacy() #2993

Closed
ewoutkramer opened this issue Dec 10, 2024 · 1 comment
Closed

Why does MakeElementStack() have to use ToTypedElementLegacy() #2993

ewoutkramer opened this issue Dec 10, 2024 · 1 comment

Comments

@ewoutkramer
Copy link
Member

When serializing to xml, with or without xxxxLegacy, the output looks the same, only the Legacy version has more whitespace (which is what the unit test is testing). But what does whitespace have to do with ToTypedElement()??? It is true we need to support the Pretty stuff on the new XML serializers, but I don't see that it makes a difference here.

Anyway, if we don't use xxxLegacy, DoesPretty and TestAppendNewLine fails.

@ewoutkramer
Copy link
Member Author

This issue has become irrelevant, since this old stack has been cleaned up and removed as part of #2923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant