From 391112e33458634562ab6190625507bd38f36b2a Mon Sep 17 00:00:00 2001 From: "jaeseung.bae" Date: Sat, 23 Mar 2024 11:15:51 +0900 Subject: [PATCH 1/3] fix: add missing error handling for migration --- x/foundation/module/module.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/x/foundation/module/module.go b/x/foundation/module/module.go index 801dfc4901..9164699777 100644 --- a/x/foundation/module/module.go +++ b/x/foundation/module/module.go @@ -116,7 +116,10 @@ func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc *codec.LegacyAmino) sd func (am AppModule) RegisterServices(cfg module.Configurator) { foundation.RegisterMsgServer(cfg.MsgServer(), keeper.NewMsgServer(am.keeper)) foundation.RegisterQueryServer(cfg.QueryServer(), keeper.NewQueryServer(am.keeper)) - keeper.NewMigrator(am.keeper).Register(cfg.RegisterMigration) + err := keeper.NewMigrator(am.keeper).Register(cfg.RegisterMigration) + if err != nil { + panic(err) + } } // InitGenesis performs genesis initialization for the foundation module. It returns From e6190449b0a415605ab087f57aa3270eebfc0336 Mon Sep 17 00:00:00 2001 From: "jaeseung.bae" Date: Sat, 23 Mar 2024 11:28:24 +0900 Subject: [PATCH 2/3] chore: update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 99d5ba22a7..6ecfb872a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,6 +47,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/foundation) [\#1283](https://github.com/Finschia/finschia-sdk/pull/1283) add init logic of foundation module accounts to InitGenesis in order to eliminate potential panic (backport #1277) * (x/collection) [\#1282](https://github.com/Finschia/finschia-sdk/pull/1282) eliminates potential risk for Insufficient Sanity Check of tokenID in Genesis (backport #1276) * (x/collection) [\#1290](https://github.com/Finschia/finschia-sdk/pull/1290) export x/collection params into genesis (backport #1268) +* (x/foundation) [\#1295](https://github.com/Finschia/finschia-sdk/pull/1295) add missing error handling for migration (backport #1171) ### Removed From 69fe2cfbbf8fd3b8e1f5cd77fc9e50b16144a8c6 Mon Sep 17 00:00:00 2001 From: "jaeseung.bae" Date: Sat, 23 Mar 2024 11:47:18 +0900 Subject: [PATCH 3/3] chore: update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ecfb872a6..43f51f19cd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,7 +47,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/foundation) [\#1283](https://github.com/Finschia/finschia-sdk/pull/1283) add init logic of foundation module accounts to InitGenesis in order to eliminate potential panic (backport #1277) * (x/collection) [\#1282](https://github.com/Finschia/finschia-sdk/pull/1282) eliminates potential risk for Insufficient Sanity Check of tokenID in Genesis (backport #1276) * (x/collection) [\#1290](https://github.com/Finschia/finschia-sdk/pull/1290) export x/collection params into genesis (backport #1268) -* (x/foundation) [\#1295](https://github.com/Finschia/finschia-sdk/pull/1295) add missing error handling for migration (backport #1171) +* (x/foundation) [\#1295](https://github.com/Finschia/finschia-sdk/pull/1295) add missing error handling for migration ### Removed