Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution ModuleAccountInvariant may be violated by users #751

Closed
0Tech opened this issue Oct 25, 2022 · 0 comments · Fixed by #752
Closed

Distribution ModuleAccountInvariant may be violated by users #751

0Tech opened this issue Oct 25, 2022 · 0 comments · Fixed by #752
Assignees
@0Tech
Labels
A: bug Something isn't working priority/critical

Comments

@0Tech
Copy link
Collaborator

0Tech commented Oct 25, 2022

Currently, any user can send certain amount of coins to x/distribution's module account, because the module account was removed from the Msg/Send, Msg/MultiSend blacklist.
However, in the upstream, cosmos-sdk, that of x/gov was the target and, its purpose was introducing the authority feature. So, we need to fix the logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working priority/critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add x/distribution's module account into blockedAddr 0Tech/finschia-sdk
1 participant
@0Tech