Check alllowed pubkey type

[dudong2]

Summary

Currently, the ValidateValidatorParams function does not check the pubkey type.
So, no error is returned even if an illegal pubkey type is passed as param.

Problem Definition

func ValidateValidatorParams(i interface{}) error {
	v, ok := i.(ocproto.ValidatorParams)
	if !ok {
		return fmt.Errorf("invalid parameter type: %T", i)
	}

	if len(v.PubKeyTypes) == 0 {
		return errors.New("validator allowed pubkey types must not be empty")
	}

	return nil
}

In the above function, only the length of v.PubKeyTypes is checked, not whether the contents are allowed or not.

t.Run("unsupported-key-type-case", func(t *testing.T) {
    testCases := []struct {
        arg       interface{}
        expectErr bool
    }{
        {ocproto.ValidatorParams{PubKeyTypes: []string{"inventedKeyType"}}, true},
    }

    for _, tc := range testCases {
        require.Equal(t, tc.expectErr, baseapp.ValidateValidatorParams(tc.arg) != nil)
    }
})

the test is passing despite the pubkey type that is not allowed in the above test.

Proposal

Add check that allowed pubkey types are correct.

• composite(bls12-381,ed25519)
• ed25519
• secp256k1
• bls12-381

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned