Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bankplus module is not extension of bank module #667

Closed
1 of 4 tasks
ulbqb opened this issue Sep 6, 2022 · 0 comments · Fixed by #705
Closed
1 of 4 tasks

Bankplus module is not extension of bank module #667

ulbqb opened this issue Sep 6, 2022 · 0 comments · Fixed by #705
Assignees
@zemyblue
Labels
A: bug Something isn't working

Comments

@ulbqb
Copy link
Member

ulbqb commented Sep 6, 2022 •
edited
Loading

Summary of Bug

There seems to be a difference between bank and bankplus SendCoinsFromModuleToAccount function whether or not the blocked address is checked.

https://github.com/line/lbm-sdk/blob/ded22b36a37906f250eb71db52bfe5b6b004aaf4/x/bank/keeper/keeper.go#L311-L325
https://github.com/line/lbm-sdk/blob/ded22b36a37906f250eb71db52bfe5b6b004aaf4/x/bankplus/keeper/keeper.go#L52-L61

It may have forgotten to add the blocked address checking to the bankplus module.

Version

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue added the A: bug Something isn't working label Sep 16, 2022
@zemyblue zemyblue self-assigned this Oct 11, 2022
@zemyblue zemyblue mentioned this issue Oct 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zemyblue zemyblue

Labels
A: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add missing blockedAddr checking in bankplus zemyblue/finschia-sdk
2 participants
@zemyblue @ulbqb