-
Notifications
You must be signed in to change notification settings - Fork 1
Comparing changes
Open a pull request
base repository: Financial-Times/dotcom-reliability-kit
base: app-info-v2.2.0
head repository: Financial-Times/dotcom-reliability-kit
compare: app-info-v2.3.0
Commits on Nov 9, 2023
-
chore: bump release-please from 15.13.0 to 16.2.0
Bumps [release-please](https://github.com/googleapis/release-please) from 15.13.0 to 16.2.0. - [Release notes](https://github.com/googleapis/release-please/releases) - [Changelog](https://github.com/googleapis/release-please/blob/main/CHANGELOG.md) - [Commits](googleapis/release-please@v15.13.0...v16.2.0) --- updated-dependencies: - dependency-name: release-please dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 5f9cba0 - Browse repository at this point
Copy the full SHA 5f9cba0View commit details
Commits on Nov 13, 2023
-
chore: bump the development-dependencies group with 12 updates
Bumps the development-dependencies group with 12 updates: | Package | From | To | | --- | --- | --- | | [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.23.0` | `7.23.3` | | [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) | `7.22.15` | `7.23.3` | | [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) | `29.5.5` | `29.5.8` | | [eslint](https://github.com/eslint/eslint) | `8.51.0` | `8.53.0` | | [@types/eslint](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/eslint) | `8.44.4` | `8.44.7` | | [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | `46.8.2` | `46.9.0` | | [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) | `4.17.19` | `4.17.21` | | @financial-times/n-express | `28.0.4` | `28.0.5` | | [undici](https://github.com/nodejs/undici) | `5.25.4` | `5.27.2` | | [@types/events](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/events) | `3.0.1` | `3.0.3` | | [@types/lodash.clonedeep](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash.clonedeep) | `4.5.7` | `4.5.9` | | [@types/ungap__structured-clone](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ungap__structured-clone) | `0.3.0` | `0.3.2` | Updates `@babel/core` from 7.23.0 to 7.23.3 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-core) Updates `@babel/eslint-parser` from 7.22.15 to 7.23.3 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.3/eslint/babel-eslint-parser) Updates `@types/jest` from 29.5.5 to 29.5.8 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Updates `eslint` from 8.51.0 to 8.53.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.51.0...v8.53.0) Updates `@types/eslint` from 8.44.4 to 8.44.7 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/eslint) Updates `eslint-plugin-jsdoc` from 46.8.2 to 46.9.0 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v46.8.2...v46.9.0) Updates `@types/express` from 4.17.19 to 4.17.21 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) Updates `@financial-times/n-express` from 28.0.4 to 28.0.5 Updates `undici` from 5.25.4 to 5.27.2 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](https://github.com/nodejs/undici/commits/v5.27.2) Updates `@types/events` from 3.0.1 to 3.0.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/events) Updates `@types/lodash.clonedeep` from 4.5.7 to 4.5.9 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash.clonedeep) Updates `@types/ungap__structured-clone` from 0.3.0 to 0.3.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ungap__structured-clone) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: "@babel/eslint-parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@types/eslint" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@types/express" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: "@financial-times/n-express" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: undici dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@types/events" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: "@types/lodash.clonedeep" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: "@types/ungap__structured-clone" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 371b584 - Browse repository at this point
Copy the full SHA 371b584View commit details
Commits on Nov 14, 2023
-
feat: add some basic app info to error pages
This is a first step towards serving nicer error pages in production. We want to show application information so that a non-engineer would be able to tell which system an error is served by. This doesn't make error pages available in production yet, that'd be a later step if we decide we want to add it. In the meantime this makes the error page more useful.
Configuration menu - View commit details
-
Copy full SHA for d1f9522 - Browse repository at this point
Copy the full SHA d1f9522View commit details -
fix: handle more error rendering edge-cases
This handles a couple of edge-cases we were missing that we _do_ handle in n-express. These are required before we can consider replacing the n-express error handling with Reliability Kit. We've done the following: * Ensure that we don't try to render the error page if the response headers have already been sent. This is recommended in the Express documentation * Ensure that the HTTP status code we send is between 400 and 599. This prevents poor error handling in apps from accidentally sending false positives by responding with 200 statuses for errors.
Configuration menu - View commit details
-
Copy full SHA for 564d950 - Browse repository at this point
Copy the full SHA 564d950View commit details
Commits on Nov 15, 2023
-
feat: add a fingerprint to serialized errors
This helps us uniquely identify errors and gives us another data point to group errors by without resorting to very complicated Splunk logic. We're intending on using this fingerprint to help Customer Care and Operations more quickly direct us to the root cause of a problem. You will also be able to more easily see the common errors that your application throws if you're using the Reliability Kit logging middleware.
Configuration menu - View commit details
-
Copy full SHA for dab223f - Browse repository at this point
Copy the full SHA dab223fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 380ec3a - Browse repository at this point
Copy the full SHA 380ec3aView commit details -
chore: bump the development-dependencies group with 2 updates
Bumps the development-dependencies group with 2 updates: [prettier](https://github.com/prettier/prettier) and @financial-times/n-express. Updates `prettier` from 3.0.3 to 3.1.0 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.0.3...3.1.0) Updates `@financial-times/n-express` from 28.0.5 to 28.1.2 --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@financial-times/n-express" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 8b5810a - Browse repository at this point
Copy the full SHA 8b5810aView commit details
Commits on Nov 16, 2023
-
feat!: render stripped back errors in production
This makes the error rendering middleware also take responsibility for outputting an error page in production environments. In production no error details are leaked and we only render the status code and message, this replicates the behaviour currently in n-express. We're doing this to reduce the footprint of n-express (#310) which currently contains some error rendering logic. Once use of the Reliability Kit error rendering middleware is more ubiquitous we should be able to remove the error handling code from n-express in a new major version. While this is technically a breaking change, if an app is using n-express then it's safe to upgrade. This is because this package behaves in exactly the same way as the n-express error handler.
Configuration menu - View commit details
-
Copy full SHA for d4e1e71 - Browse repository at this point
Copy the full SHA d4e1e71View commit details
Commits on Nov 20, 2023
-
feat: expose error fingerprints as an HTTP header
This sets a new header in the error rendering middleware which exposes the fingerprint of an error if it has one. This allows us to better debug in production environments - our logs also include this fingerprint so that you can map our generic error pages to the type of error that occurred and where in the code it was thrown. Some considerations: * If an app is behind a CDN and error pages are cached, then we will need to vary on the `x-error-fingerprint` header in order for this to be useful - otherwise the first fingerprint will get cached * Not all apps will get this functionality at the same time. They'll need to either start using the error rendering middleware or bump the major version, because this is landing as part of a breaking change
Configuration menu - View commit details
-
Copy full SHA for 2357f2d - Browse repository at this point
Copy the full SHA 2357f2dView commit details -
fix: stop using deprecated
x-
header prefixThis way of defining headers is deprecated: https://datatracker.ietf.org/doc/html/rfc6648 Co-Authored-By: Alex Muller <alexmuller@users.noreply.github.com> Co-Authored-By: Cynthia Mbulu <CyntiBinti@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5de9864 - Browse repository at this point
Copy the full SHA 5de9864View commit details -
Configuration menu - View commit details
-
Copy full SHA for e78216f - Browse repository at this point
Copy the full SHA e78216fView commit details -
chore: bump the development-dependencies group with 3 updates
Bumps the development-dependencies group with 3 updates: [eslint](https://github.com/eslint/eslint), [release-please](https://github.com/googleapis/release-please) and @financial-times/n-express. Updates `eslint` from 8.53.0 to 8.54.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.53.0...v8.54.0) Updates `release-please` from 16.2.0 to 16.3.0 - [Release notes](https://github.com/googleapis/release-please/releases) - [Changelog](https://github.com/googleapis/release-please/blob/main/CHANGELOG.md) - [Commits](googleapis/release-please@v16.2.0...v16.3.0) Updates `@financial-times/n-express` from 28.1.2 to 28.1.3 --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: release-please dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@financial-times/n-express" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 3edbe72 - Browse repository at this point
Copy the full SHA 3edbe72View commit details
Commits on Nov 21, 2023
-
fix: bump pino from 8.15.1 to 8.16.2
Bumps [pino](https://github.com/pinojs/pino) from 8.15.1 to 8.16.2. - [Release notes](https://github.com/pinojs/pino/releases) - [Commits](pinojs/pino@v8.15.1...v8.16.2) --- updated-dependencies: - dependency-name: pino dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for c7a51d6 - Browse repository at this point
Copy the full SHA c7a51d6View commit details -
fix: switch to using streams for prettification
We encountered an issue in pino-pretty where, if the `--require` argument is used, the required file will be loaded twice. This can cause some weird and unexpected issues. We raised a bug with pino-pretty here: https://github.com/pinojs/pino-pretty/issues/478 Switching to using pino-pretty as a stream resolves this issue.
Configuration menu - View commit details
-
Copy full SHA for 7abae5a - Browse repository at this point
Copy the full SHA 7abae5aView commit details -
chore: refactor the prettifier import
This hopefully makes the prettifier logic easier to read and understand. The variables are named for what they are and I've split out the loading of the pino-pretty library from the logic to determine whether it's allowed to be used.
Configuration menu - View commit details
-
Copy full SHA for e87bee3 - Browse repository at this point
Copy the full SHA e87bee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4395f66 - Browse repository at this point
Copy the full SHA 4395f66View commit details
Commits on Nov 22, 2023
-
fix: bump svgo from 3.0.2 to 3.0.4
Bumps [svgo](https://github.com/svg/svgo) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/svg/svgo/releases) - [Changelog](https://github.com/svg/svgo/blob/main/CHANGELOG-old.md) - [Commits](svg/svgo@v3.0.2...v3.0.4) --- updated-dependencies: - dependency-name: svgo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 6b65f71 - Browse repository at this point
Copy the full SHA 6b65f71View commit details -
chore: bump the development-dependencies group with 3 updates
Bumps the development-dependencies group with 3 updates: [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest), [typescript](https://github.com/Microsoft/TypeScript) and [@types/ungap__structured-clone](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ungap__structured-clone). Updates `@types/jest` from 29.5.8 to 29.5.10 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Updates `typescript` from 5.2.2 to 5.3.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.2.2...v5.3.2) Updates `@types/ungap__structured-clone` from 0.3.2 to 0.3.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ungap__structured-clone) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@types/ungap__structured-clone" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for ab0c24f - Browse repository at this point
Copy the full SHA ab0c24fView commit details
Commits on Nov 23, 2023
-
feat: add useIsoTimeFormat option to format log timestamps
Simeon reported in the cp-reliability Slack channel that they would prefer to have more human readable timestamps in logs. Pino supports this with the stdTimeFunctions object which can be set on the withTimestamps option (that we're using already). This commit exposes the Pino configuration with a new Reliability Kit logger option called useIsoTimeFormat. We anticipate that in the future we will probably switch this to be the default (which will be a breaking change) and potentially remove the option completely so that timestamps are always logged. Note that this timestamp option is on the log body. We do already have the log ingestion datetime recorded, even when withTimestamps is false. Co-Authored-By: Rowan Manning <rowanmanning@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d22e24a - Browse repository at this point
Copy the full SHA d22e24aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87e3d00 - Browse repository at this point
Copy the full SHA 87e3d00View commit details
Commits on Nov 24, 2023
-
chore: bump the development-dependencies group with 2 updates
Bumps the development-dependencies group with 2 updates: [undici](https://github.com/nodejs/undici) and @financial-times/n-express. Updates `undici` from 5.27.2 to 5.28.0 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.27.2...v5.28.0) Updates `@financial-times/n-express` from 28.1.3 to 28.2.0 --- updated-dependencies: - dependency-name: undici dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies - dependency-name: "@financial-times/n-express" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 3324ac8 - Browse repository at this point
Copy the full SHA 3324ac8View commit details
Commits on Nov 28, 2023
-
chore: bump the development-dependencies group with 3 updates
Bumps the development-dependencies group with 3 updates: [release-please](https://github.com/googleapis/release-please), [undici](https://github.com/nodejs/undici) and @financial-times/n-express. Updates `release-please` from 16.3.0 to 16.3.1 - [Release notes](https://github.com/googleapis/release-please/releases) - [Changelog](https://github.com/googleapis/release-please/blob/main/CHANGELOG.md) - [Commits](googleapis/release-please@v16.3.0...v16.3.1) Updates `undici` from 5.28.0 to 5.28.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.0...v5.28.1) Updates `@financial-times/n-express` from 28.2.0 to 28.3.0 --- updated-dependencies: - dependency-name: release-please dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: undici dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development-dependencies - dependency-name: "@financial-times/n-express" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 9359fdd - Browse repository at this point
Copy the full SHA 9359fddView commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ca28b38 - Browse repository at this point
Copy the full SHA ca28b38View commit details -
feat: render the error fingerprint
This renders the error fingerprint on both the local development and production error pages so that apps that aren't behind FT.com will also get a fingerprint output without having to handle it themselves.
Configuration menu - View commit details
-
Copy full SHA for 1cbb9fa - Browse repository at this point
Copy the full SHA 1cbb9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 253c6d3 - Browse repository at this point
Copy the full SHA 253c6d3View commit details
There are no files selected for viewing