Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stutters on SPL v.0.0.4.1 #35

Closed
GreenComfyTea opened this issue Mar 20, 2024 · 12 comments
Closed

[Bug] Stutters on SPL v.0.0.4.1 #35

GreenComfyTea opened this issue Mar 20, 2024 · 12 comments

Comments

@GreenComfyTea
Copy link

GreenComfyTea commented Mar 20, 2024

Describe The Problem

I have received a number of reports about stuttering/fps pacing. The longer they played the worse were the stutters. Downgrading to SPL v0.0.4 seems to fix the issue.

Screenshot 1

image

Screenshot 2

image

Screenshot 3

image

Screenshot 4

image

Screenshot 5

image

To Reproduce

...

Expected Behavior

No stutters.

Priority

Suggested P2 Priority. The game is unplayable for some players.

@GreenComfyTea GreenComfyTea changed the title [Bug] Stutter on SPL v.0.0.4.1 [Bug] Stutters on SPL v.0.0.4.1 Mar 20, 2024
@Fexty12573
Copy link
Owner

Yikes. Could you ask people to try 0.0.4.1 but have PrimitiveRenderingEnabled set to false in the config? I didn't change many things in 0.0.4.1. And if possible let me know if there are other people that don't have stutters with 0.0.4.

@GreenComfyTea
Copy link
Author

Sure will!

There is 1 more person who tried v0.0.4, thou on v0.0.4.1 they encountered the stutters only once, so they are not a reliable example.

Screenshot

image

@GreenComfyTea
Copy link
Author

1 person says PrimitiveRenderingEnabled = false fixes the issue.

Screenshot

image

@Fexty12573
Copy link
Owner

Hmmm ok might be some sort of memory leak then. I did quite heavily revamp that system with 0.0.4.1. Will check when I get home.

@Fexty12573
Copy link
Owner

Fexty12573 commented Mar 20, 2024

Actually it's probably the GC. I pin a lot of stuff which most likely results in fragmentation so the GC has longer and longer. I'll probably change these arrays to be native memory instead of managed Lists. I will have to make a 0.0.4.2 release anyway so this works. (Or should I just bump it to 0.0.5? Doesn't really matter I guess)

@GreenComfyTea
Copy link
Author

GreenComfyTea commented Mar 20, 2024

There also was 1 another person who said that alt-tabbing was increasing RAM each time. I couldn't replicate it + the person was quite rude, so it might have been just a troll.

@Fexty12573
Copy link
Owner

Fexty12573 commented Mar 20, 2024

I pushed a potential fix for this in f921f36. If possible, could you test this? If this fixes it I will make a new release either today or tomorrow.

@GreenComfyTea
Copy link
Author

GreenComfyTea commented Mar 20, 2024

I would if I could. But I personally have 0 issues. Probably, my PC just tanks it. I will ask others to try it out.

@GreenComfyTea
Copy link
Author

There is 1 more person who tried v0.0.4, thou on v0.0.4.1 they encountered the stutters only once, so they are not a reliable example.

This person says no stutters.

Screenshot

image

@Fexty12573
Copy link
Owner

Hmmm. I think I'll just make a 0.0.5 release. Didn't change much in that so it shouldn't require an update on your end.

@Fexty12573
Copy link
Owner

Can I close this? Or do the stutters persist?

@GreenComfyTea
Copy link
Author

GreenComfyTea commented Mar 25, 2024

I haven't received any reports about the stutters still being present. Closing it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants