Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview button too small? #54

Closed
FelixBaensch opened this issue Mar 7, 2024 · 20 comments
Closed

Overview button too small? #54

FelixBaensch opened this issue Mar 7, 2024 · 20 comments
Assignees
Labels
bug Something isn't working

Comments

@FelixBaensch
Copy link
Owner

image

Linux Mint

@JonasSchaub
Copy link
Collaborator

JonasSchaub commented Mar 7, 2024

Does the histogram button in the fragments tab looks the same?

@FelixBaensch
Copy link
Owner Author

image

image

@JonasSchaub
Copy link
Collaborator

All of these buttons have the MORTAR standard size. I guess this has to be increased then. What do you think?

@FelixBaensch
Copy link
Owner Author

Maybe we have to explicitly set the font size, since this looks like an OS depending problem

@JonasSchaub
Copy link
Collaborator

this looks like an OS depending problem

...definitely. I've done a quick research and it seems to be discouraged to define a general "look and feel" for a JavaFx app. This way, the app can look "native" in each OS which is nice.

Setting the font can be done via the style sheet, e.g.:
.root{ -fx-font-size: 9pt; }
Setting the font type would be helpful but would make it harder to port MORTAR to other OS because the specific font might not be installed on the system. But I actually think the font is the bigger problem here than the font size...

@JonasSchaub
Copy link
Collaborator

Are you starting MORTAR from IntelliJ on your Linux system? Or via the JAR? So how could I give you a version with a defined font size to try it out on your system?

@FelixBaensch
Copy link
Owner Author

Both, so both will be fine

@JonasSchaub
Copy link
Collaborator

Could you then go to my sonar-issues-fix branch and try it out there? I simply added .root{ -fx-font-size: 9pt; } to the style sheet. Feel free to play around with the value.

@FelixBaensch
Copy link
Owner Author

image

image

image

@FelixBaensch
Copy link
Owner Author

It fixed the overview button on the main page but not the rest

@JonasSchaub
Copy link
Collaborator

Then we either have to make the buttons bigger or the text even smaller... "Export CSV" and "Export PDF" could also be abbreviated to "CSV" and "PDF". What do you think?

@FelixBaensch
Copy link
Owner Author

"Export CSV" and "Export PDF" could also be abbreviated to "CSV" and "PDF". What do you think?

That was my suggestion from the start

@JonasSchaub
Copy link
Collaborator

I have done that on the same branch as before. I have also exchanged the "Histogram" button label with "Plot". I thought it sounds like a command "plot frequencies" and would fit. I am missing ideas how else to abbreviate the histogram button label. What do you think? And could you please check all the buttons again?

@JonasSchaub JonasSchaub added the bug Something isn't working label Mar 27, 2024
@JonasSchaub
Copy link
Collaborator

@FelixBaensch could you please test this again on my "sonar-issues-fix" branch? I would like to solve this for the new release.

@FelixBaensch
Copy link
Owner Author

Sorry for the late response. I probably won't be able to do it this week, but I'll test it at the beginning of next week.

@JonasSchaub
Copy link
Collaborator

No worries, this week is basically over anyway 😄

@FelixBaensch
Copy link
Owner Author

CSV and PDF look good to me, "Plot" might be a bit confusing. How about "Hist" or "Histo"?

@FelixBaensch
Copy link
Owner Author

FelixBaensch commented Apr 2, 2024

  • Combo boxes are weird:

image

image

  • "Fragment" button is too small, "Add" button is empty

image

@JonasSchaub JonasSchaub self-assigned this Apr 3, 2024
@JonasSchaub
Copy link
Collaborator

@FelixBaensch please go to branch "issue-54-button-sizes" and let me know what you think.

@FelixBaensch
Copy link
Owner Author

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants