Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary vertical scroll bar in items tab #100

Closed
JonasSchaub opened this issue Apr 25, 2024 · 9 comments
Closed

Unnecessary vertical scroll bar in items tab #100

JonasSchaub opened this issue Apr 25, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@JonasSchaub
Copy link
Collaborator

image

A related problem is that after fragmentation, the gap at the bottom of the molecules tab becomes larger.

Before fragmentation:

image

After fragmentation:

image

As I understand it, the image structure heights of the imported molecule data models are updated when the fragments and items tabs are created. For the items tab, they have to be smaller than before to accommodate the horizontal scroll bar at the bottom and the doubled table header height (fragments column is split into multiple sub-columns). The problem is: this reflects back to image structure heights in the molecules tab, increasing the gap at the bottom.

I see two possible solutions:

  1. (quick and dirty) remove the overall fragments column in the items tab (but keep separate "Fragment 1", "Fragment 2", etc columns) and then tweak the image structure height adjustment in a way that doe snot make things much worse in the molecules tab but makes the vertical scroll bar in the items tab disappear.
  2. (touching the data models and more complex) separate the image structure height property of the molecule data models into separate properties, i.e. image structure height for molecules tab, fragments tab, items tab, etc.

To discuss and probably not fix for v1.2.

@JonasSchaub JonasSchaub added the bug Something isn't working label Apr 25, 2024
@FelixBaensch
Copy link
Owner

Are you sure, I don't think the structures once drawn are updated just because a new tab is added.
I would rather try to customize the "setImageStructureHeight" method in "GuiUtil". The easiest way would be to add another minuend in line 539 by trial and error.

@FelixBaensch
Copy link
Owner

A related problem is that after fragmentation, the gap at the bottom of the molecules tab becomes larger.

I can't reproduce this on Linux.

@JonasSchaub
Copy link
Collaborator Author

Are you sure, I don't think the structures once drawn are updated just because a new tab is added.

I can't reproduce this on Linux.

Did you switch pages after the fragmentation was completed? Drawn structures or rather generated and displayed pages are not updated but they will be updated when you switch pages and a new page is created.

@JonasSchaub
Copy link
Collaborator Author

I would rather try to customize the "setImageStructureHeight" method in "GuiUtil". The easiest way would be to add another minuend in line 539 by trial and error.

I tried that but then, the gap at the bottom of the molecules tab becomes even larger.

@FelixBaensch
Copy link
Owner

Let us meet about this

@JonasSchaub
Copy link
Collaborator Author

Gladly, can you suggest a time slot?

@FelixBaensch
Copy link
Owner

Friday morning before 11 am

@JonasSchaub
Copy link
Collaborator Author

Friday morning before 11 am

Friday at 10 am would suit me, since I'm meeting the students at 9.

@JonasSchaub
Copy link
Collaborator Author

Just as a related note: there is another "unnecessary" scroll bar at the bottom of the histogram view.

@JonasSchaub JonasSchaub self-assigned this May 3, 2024
This was referenced May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants