-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put windows poppler binaries in a separate package #383
Comments
Thanks @dumbasPL, I had considered just having a duplicate separate package without the windows binaries, however had never thought about using an optionalDependency! I'll take a look (though I won't be able to until next week). |
Any progress on this? |
Hiya, unfortunately not, been a bit swamped with other projects. |
Hi, I've noticed you added the Essentially things that need to be done are:
|
Thanks @dumbasPL, yes I put the tag on because I was struggling to find the time to sort this. Should hopefully be able to sort it some time this year! |
Hmm I see you built poppler 24-02 as a 64bit binary artifact and am unable to run on Enterprise 32bit (yes like NHS I use old reliable kit so stuck at 2022-02 x32 build or use Xpdf 2024-4.0.5) I also note your NPM version here implies a 32 bit build of binaries but cannot find where they may be downloaded without an NPM install |
Prerequisites
Description
Hello, I've noticed that this package bundles all the windows binaries regardless of what platform it's being installed on.
I suggest putting all the windows binaries into a separate package and adding
to that packages
package.json
.You can then include that package using
optionalDependencies
which will only install the package if we are on windows and ignore it on any other platform.Doing this will remove over 99% of the unpacked package size.
Having to include almost 50MB of unused files in a docker image is not great (especially since you need to install the Linux binaries on top of that anyway).
Also might as well include
while you're at it since the binaries won't work on x86 or arm builds of windows.
The text was updated successfully, but these errors were encountered: