Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder-based POJO deserializer should pass builder instance, not type, to handleUnknownVanilla() #2415

Closed
wants to merge 1 commit into from

Conversation

tsachev
Copy link

@tsachev tsachev commented Aug 7, 2019

We are hitting #822 too. What we observe is that handleUnknownVanilla is called with the bulider type instead of the instance, when the builder has constructor with parameters.

@tsachev tsachev changed the title Fix #882 Fix #822 Aug 7, 2019
@tsachev tsachev changed the title Fix #822 Fix #882 Aug 7, 2019
@tsachev tsachev changed the title Fix #882 Fix #822 Aug 7, 2019
@cowtowncoder
Copy link
Member

Ok thank you for submitting things. I will have a look, seems legit, just want to make sure I understand.

@cowtowncoder
Copy link
Member

Ok. Took me a while to check since there are other methods where argument is "beanOrType", but I think you are right in that in this case this should not be the case. It might be necessary in future to split method in 2 (that is, separate for builder- / non-builder cases), but for now I think fix makes sense.

I will merge this manually since I'll want it in 2.10 and will add minor renaming.
Thank you for contributing the fix!

@cowtowncoder cowtowncoder changed the title Fix #822 Builder-based POJO deserializer should pass builder instance, not type, to handleUnknownVanilla() Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants