Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting from CRS 7405 #72

Open
jennet opened this issue Oct 27, 2021 · 3 comments
Open

converting from CRS 7405 #72

jennet opened this issue Oct 27, 2021 · 3 comments

Comments

@jennet
Copy link

jennet commented Oct 27, 2021

Hi there
I am trying out your library as a way of converting from CRS 7405 (BNG 3D) into wgs84. As there wasn't any docs examples I started at the tests to see if there were code snippets I could use as examples there.

This led to some confusion as the code used there turns out to be unreleased (once I found this info in the changelog it became a lot clearer)

I'm getting further now that I'm using the previous jts/gf but just noting here in case you could provide examples for this based on the currently released codebase (or keep unreleased code on a different branch or something, going forward)

Thanks for the library it's great to have so many useful functions in one place!

@jennet
Copy link
Author

jennet commented Oct 27, 2021

related Q:
is there a way to easily read a co-ordinate string (e.g. "301703.520 505030.900 20.586 301720.120 505011.700 20.738 301720.620 505011.400 20.745") into a jts/linestring?
low priority feature request to extend this fn to allow developer to specify a 3 coord system :)

@jennet jennet changed the title get-geometry-factory confusion converting from CRS 7405 Oct 27, 2021
@worace
Copy link
Contributor

worace commented Oct 27, 2021

Can you give more info like some function names or links to code for the things you are saying are unreleased? Sorry for that confusion, perhaps we need to do another release if there is stuff in there that's not published.

For docs, the best thing would be to add some more doc strings so they will show up in the published docs here

Some code-snippet examples for the readme could be good too. I probably won't have time to do this any time soon but if you wanted to take a stab it it that would be much appreciated.

On your last point, any chance you could turn your list of coords into a valid GIS text format like WKT or GeoJSON? For more complicated geometries that's probably the most reliable way to handle that sort of parsing.

@jennet
Copy link
Author

jennet commented Oct 28, 2021

sorry, the function name was in the old label of the issue and then I started tangenting off asking other things... it's get-geometry-factory in the crs namespace (and others), have a look through the "unreleased" section of the changelog and it's all there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants