Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instance_id_map and holdings_id_map still retrain iteration_identifier in filename #364

Closed
jermnelson opened this issue Sep 30, 2022 · 0 comments · Fixed by #369
Closed

instance_id_map and holdings_id_map still retrain iteration_identifier in filename #364

jermnelson opened this issue Sep 30, 2022 · 0 comments · Fixed by #369
Assignees
@fontanka16

Comments

@jermnelson
Copy link
Contributor

When running instances of BibsTransformer and HoldingsCsvTransformer, the instance_id_map and holdings_id_map still have the iteration_identifier as part of their file names. Suggest changing these files to just instance_id_map.json and holdings_id_map.json to follow the new pattern.

Screenshot of recent iteration run:
Screen Shot 2022-09-30 at 2 33 04 PM
@fontanka16 fontanka16 self-assigned this Oct 4, 2022
@fontanka16 fontanka16 linked a pull request Oct 5, 2022 that will close this issue
Remove iteration identifier from id map paths #369
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fontanka16 fontanka16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove iteration identifier from id map paths FOLIO-FSE/folio_migration_tools
2 participants
@jermnelson @fontanka16