Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform more repetitions (of increment) for RTC concurrency testing #746

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

ptheywood
Copy link
Member

RTC runtime was too fast for reliable timing, so a longer running kernel was required.

Closes #745

RTC runtime was too fast for reliable timing, so a longer running kernel was required.
@ptheywood
Copy link
Member Author

ptheywood commented Dec 6, 2021

@Robadob - could you test this when you have time to see if this has resolved the failure for you (windows, 1080), by running the following a number of times and seeinf if it ever fails?
First run will be a while as it RTC's 4 kernels, subsequent ones should be 80 to 200ms depending on how long the cuda context takes to initialsie on windows + a little bit of time.

./bin/Release/tests --gtest_filter="TestCUDASimulationConcurrency.RTCLayerConcurrency"

(I'll re-run CI tomorrow when github's hopefully more stable)

I've ran it ~ 25 times successfully on my 3060ti on windows (current master failed once for me, but only when running the full TestCudaSimulationConcurreny suite, not just the RTC test so this may not be 100%)

@Robadob
Copy link
Member

Robadob commented Dec 7, 2021

I'll try and remember to do it tomorrow,

@Robadob
Copy link
Member

Robadob commented Dec 7, 2021

Just ran the version that failed yesterday again, with less other stuff using GPU, and it passed.

Rebuilt it with this branch and it also passed.

@ptheywood
Copy link
Member Author

I'll assume that it's good for now then, although we may need to adjust this further in the future

@ptheywood ptheywood merged commit 769e4a0 into master Dec 7, 2021
@ptheywood ptheywood deleted the testfix-rtc-timing branch December 7, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittant RTCLayerConcurrency Test Failure
2 participants