Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SEATBELTS checks for reserved names across DeviceAPI. #700

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Oct 1, 2021

Haven't added any additional tests, or even built the code it's just a trivial change.
Note there aren't any reserved name checks on variable getters, because those are used internally in a few places (and a user can do no harm with a get only).
Closes #699

@Robadob Robadob requested a review from ptheywood October 1, 2021 14:59
@mondus mondus added this to the v2.0.0-alpha.2 milestone Oct 6, 2021
@mondus mondus merged commit 9cabd42 into master Oct 6, 2021
@mondus mondus deleted the SEATBELTS_DeviceAPI_ReservedName branch October 6, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEATBELTS missing from DeviceAPI variable name begining with _ check
2 participants