Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageRoot protocols #150

Open
alahiff opened this issue Sep 23, 2021 · 2 comments · May be fixed by #174
Open

StorageRoot protocols #150

alahiff opened this issue Sep 23, 2021 · 2 comments · May be fixed by #174

Comments

@alahiff
Copy link
Collaborator

alahiff commented Sep 23, 2021

In the documentation it's mentioned that Storage Roots must contain a protocol, but this is not enforced. For local file storage in a local registry many users might not include file:// at the beginning, so we probably should enforce this.

@alahiff
Copy link
Collaborator Author

alahiff commented Sep 23, 2021

There are two options:

  1. Use a simple regex to allow anything of the appropriate form, e.g. superstore://.
  2. Have a predefined list of allowed protocols. If we go down this route, we should probably switch our custom URIField to Django's URLField but extend the allowed list of validators to at least include file:// (see https://docs.djangoproject.com/en/2.2/ref/validators/#urlvalidator)

@richardreeve
Copy link
Member

I think this is a good idea, but something to implement after we submit along with the slight change to the schema (#124). We need to make sure that we can continue to make updated plots until Monday night :). And I'd go with 1 in the first instance and we can get clever later if we decide it's a good idea...

@alahiff alahiff linked a pull request Oct 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants