Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recall votes can't be changed between successive votes, sometimes #6172

Closed
ChessBerry opened this issue May 12, 2024 · 1 comment
Closed
Labels
area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game

Comments

@ChessBerry
Copy link
Contributor

Describe the bug
In this game #22477391 our team voted for recall twice. The first time we voted against the recall 1:3, but shortly thereafter everyone of us 4 on the team voted for a recall 4:0 in the second vote, but this seemingly didn't end up changing any of the votes of players that previously voted no. There vote was seemingly stuck on "no" even if they voted "yes" afterwards.

To Reproduce
I don't know. Recall seems generally unstable these days, but I haven't found a pattern yet.

Expected behavior
Recall votes should be counted correctly.

Screenshots
Screenshot_323

Screenshot_324 Screenshot_325

Additional context
Game and client logs:
game_22477391.log
client.log

@MrRowey MrRowey added area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game labels May 14, 2024
@lL1l1
Copy link
Contributor

lL1l1 commented Dec 12, 2024

Should be fixed among the many fixes in #6396, even though I haven't replicated this bug exactly, I did catch a lot of edge cases.

The reason for the bug might have been the number of votes to end a recall early not calculating correctly or old votes not being cleared for dead players, both reasons are fixed.

@lL1l1 lL1l1 closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

No branches or pull requests

3 participants