Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint configuration to reflect the project style #289

Closed
parkerbjur opened this issue Mar 10, 2022 · 1 comment
Closed

Update eslint configuration to reflect the project style #289

parkerbjur opened this issue Mar 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@parkerbjur
Copy link
Contributor

Problem:
I noticed that currently there are quite a few eslint warnings. They also are all from a limited selection of warnings. 'no-console', '@typescript-eslint/no-explicit-any', and 'react-hooks/exhaustive-deps' representing all of the 46 warnings. It seems to me that it should be decided if these are an actual problem for the style and be rectified or the eslint config file should be updated to enforce the style which is actually desired.

Proposed Solution:

  • especially for the 'no-console' rule it seems like console.error() should be allowed and not throw a warning. Console.log() and console.warn() could still throw a warning.
  • the other two rules are a bit more complicated and require work arounds which are beyond my knowledge of the code base.

It seems like this issue will only get worse as the code base gets larger and it should be decided sooner than later what the code style should be. I think the easiest change is to 'no-console', the other two should probably remain warnings.

@parkerbjur parkerbjur added the enhancement New feature or request label Mar 10, 2022
@jurgelenas
Copy link
Member

especially for the 'no-console' rule it seems like console.error() should be allowed and not throw a warning. Console.log() and console.warn() could still throw a warning.

Agree on this one. If you want, you can send a pull request fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants