You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem:
I noticed that currently there are quite a few eslint warnings. They also are all from a limited selection of warnings. 'no-console', '@typescript-eslint/no-explicit-any', and 'react-hooks/exhaustive-deps' representing all of the 46 warnings. It seems to me that it should be decided if these are an actual problem for the style and be rectified or the eslint config file should be updated to enforce the style which is actually desired.
Proposed Solution:
especially for the 'no-console' rule it seems like console.error() should be allowed and not throw a warning. Console.log() and console.warn() could still throw a warning.
the other two rules are a bit more complicated and require work arounds which are beyond my knowledge of the code base.
It seems like this issue will only get worse as the code base gets larger and it should be decided sooner than later what the code style should be. I think the easiest change is to 'no-console', the other two should probably remain warnings.
The text was updated successfully, but these errors were encountered:
especially for the 'no-console' rule it seems like console.error() should be allowed and not throw a warning. Console.log() and console.warn() could still throw a warning.
Agree on this one. If you want, you can send a pull request fixing it.
Problem:
I noticed that currently there are quite a few eslint warnings. They also are all from a limited selection of warnings. 'no-console', '@typescript-eslint/no-explicit-any', and 'react-hooks/exhaustive-deps' representing all of the 46 warnings. It seems to me that it should be decided if these are an actual problem for the style and be rectified or the eslint config file should be updated to enforce the style which is actually desired.
Proposed Solution:
It seems like this issue will only get worse as the code base gets larger and it should be decided sooner than later what the code style should be. I think the easiest change is to 'no-console', the other two should probably remain warnings.
The text was updated successfully, but these errors were encountered: