Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Redis-Sentinel #499

Closed
XVincentX opened this issue Nov 2, 2017 · 4 comments
Closed

Support for Redis-Sentinel #499

XVincentX opened this issue Nov 2, 2017 · 4 comments
Assignees
Milestone

Comments

@XVincentX
Copy link
Member

XVincentX commented Nov 2, 2017

Express Gateway can only work with a single Redis instance at the moment.

Sentinel provides high scalability for Redis and it's a mandatory step to go in production when you're storing important data (such as keys and so on and so forth).

We need to implement support for it.

Battle plan

  • Evaluate a new Redis client. The current one does not support Sentinel natively and, although there's a library that can monkey patch the methods. It's not maintained as well as its usage is discouraged. We should use ioredis as it is the official solution.

  • We're using FakeRedis when the emulate flag is true (for testing purposes as well in memory instances). Is this going to work even when the client will be switched? There's an alternative

@XVincentX
Copy link
Member Author

XVincentX commented Nov 3, 2017

See the battle plan in the PR.

@DrMegavolt
Copy link
Contributor

ioredis seems to be the way to go. it is recommended client on the redis page

we should not remove in memory storage. it is crucial for getting started experience.
and we should not run unit tests against real redis

bugs seems to be non-critical. should be possible to fix

@DrMegavolt
Copy link
Contributor

and *Async is just a hack to modernize old school library, obviously all xxxAsync methods can be renamed to normal looking methods

@XVincentX
Copy link
Member Author

This just happened. #537 for followups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants