Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create type definition files for APIs used in App #547

Closed
hayata-suenaga opened this issue Jun 12, 2023 · 3 comments
Closed

Create type definition files for APIs used in App #547

hayata-suenaga opened this issue Jun 12, 2023 · 3 comments
Assignees
@hayata-suenaga
Labels
Daily Engineering NewFeature

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Jun 12, 2023 •
edited
Loading

Part of Expensify/App#16665 issues.

  • Design doc
  • This library is used in other Expensify repositories, and the change should not affect these repositories.
@hayata-suenaga hayata-suenaga self-assigned this Jun 12, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Jun 12, 2023
Closed
20 tasks
@MelvinBot MelvinBot mentioned this issue Jun 20, 2023
Closed
@blazejkustra blazejkustra mentioned this issue Jun 21, 2023
Merged
2 tasks
@blazejkustra
Copy link
Contributor

I opened a PR with type definitions for expensify-common here!

@hayata-suenaga
Copy link
Contributor Author

Review of the PR is in progress 👍

@hayata-suenaga
Copy link
Contributor Author

The PR has been merged and the definition files were created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayata-suenaga hayata-suenaga

Labels
Daily Engineering NewFeature
Projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blazejkustra @hayata-suenaga