Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fetch StagingDeployCash issues in all states #3647

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Following up on #3173. I always forget that the default value of the state parameter is open, not all. So octokit.issues.listForRepo by default only gets open issues.

Fixed Issues

Failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2851543811?check_suite_focus=true

Tests

Merge to test!

QA Steps

None.

Tested On

N/A – GitHub only.

@roryabraham roryabraham self-assigned this Jun 17, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 17, 2021 17:50
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team June 17, 2021 17:51
@roryabraham
Copy link
Contributor Author

Merging to hopefully unblock QA!

@roryabraham roryabraham merged commit 9ccfeba into main Jun 17, 2021
@roryabraham roryabraham deleted the Rory-FixStagingDeployCash branch June 17, 2021 18:17
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.70-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants