Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native for SNYK vulnerability #3446

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Conversation

timszot
Copy link
Contributor

@timszot timszot commented Jun 8, 2021

Details

Updates react-native to 0.64.1 due to a SNYK vulnerability.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/166320

Tests

  1. Loaded the app on the various platforms and tested out basic functionality.

QA Steps

  1. Normal regression

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@timszot timszot requested a review from a team as a code owner June 8, 2021 22:08
@timszot timszot self-assigned this Jun 8, 2021
@timszot timszot requested a review from marcaaron June 8, 2021 22:08
@MelvinBot MelvinBot requested review from nickmurray47 and AndrewGable and removed request for a team June 8, 2021 22:09
@AndrewGable AndrewGable removed their request for review June 8, 2021 22:10
@@ -11,4 +11,4 @@ jest.mock('react-native-reanimated', () => {
});

// Silence the warning: Animated: `useNativeDriver` is not supported because the native animated module is missing
jest.mock('react-native/Libraries/Animated/src/NativeAnimatedHelper');
jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed per this SO answer because our test were failing.

@timszot timszot changed the title [HOLD] Update react-native for SNYK vulnerability Update react-native for SNYK vulnerability Jun 8, 2021
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCGW

@marcaaron marcaaron merged commit 072c916 into main Jun 8, 2021
@marcaaron marcaaron deleted the timszot_snykReactNative branch June 8, 2021 23:42
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

🚀 Deployed to staging in version: 1.0.65-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants