Apply localization to all hard coded text in the Expensify.cash app #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
49 tasks
|
🚀 Deployed to staging in version: 1.0.65-4🚀
|
|
Anything that needs to be QAd here? CC @Jag96 @eVoloshchak |
|
Ah no, we can check this off @isagoico! |
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes some issues that were discovered in this pull-request.
thisreference is lost inshowDocumentPickercommon.settingsin languages/enshowDocumentPickeris only printed on the console, it's not intended to be seen by the end userand it does not need translated prefix
Fixed Issues
Fixes #2408