Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Bump Onyx version #2200

Merged
merged 1 commit into from
Apr 1, 2021
Merged

[No QA] Bump Onyx version #2200

merged 1 commit into from
Apr 1, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 1, 2021

Details

See Issue

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/159086

Tests

QA Steps

No real QA to perform here besides standard regressions as these changes shouldn't effect the application in any major way.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Apr 1, 2021
@marcaaron marcaaron requested a review from a team as a code owner April 1, 2021 17:24
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team April 1, 2021 17:25
@marcaaron marcaaron requested a review from Julesssss April 1, 2021 17:25
@marcaaron
Copy link
Contributor Author

Just testing web/iOS. Everything seems fine so I think QA will catch anything major.

@Julesssss
Copy link
Contributor

No obvious regressions to pages which depend on mergeCollection. LGTM

@Julesssss Julesssss merged commit b2fa6b9 into master Apr 1, 2021
@Julesssss Julesssss deleted the marcaaron-bumpOnyxVersion branch April 1, 2021 17:52
@OSBotify
Copy link
Contributor

OSBotify commented Apr 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants