From a6d4ba24de080741ada26d0b5ac56ae216671cab Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 25 Nov 2021 10:26:49 -0700 Subject: [PATCH 1/5] encode url --- src/CONST.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CONST.js b/src/CONST.js index 199c13733afd..71d77776ccc5 100755 --- a/src/CONST.js +++ b/src/CONST.js @@ -179,7 +179,7 @@ const CONST = { PRIVACY_URL: 'https://use.expensify.com/privacy', LICENSES_URL: 'https://use.expensify.com/licenses', PLAY_STORE_URL: 'https://play.google.com/store/apps/details?id=com.expensify.chat&hl=en', - ADD_SECONDARY_LOGIN_URL: 'settings?param={%22section%22:%22account%22}', + ADD_SECONDARY_LOGIN_URL: 'settings?param=%7B%22section%22:%22account%22,%22openModal%22:%22secondaryLogin%22%7D', MANAGE_CARDS_URL: 'domain_companycards', FEES_URL: 'https://use.expensify.com/fees', CFPB_PREPAID_URL: 'https://cfpb.gov/prepaid', From 05bc3ca1983aee57b7de90e56872afaebe34830d Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 25 Nov 2021 10:27:29 -0700 Subject: [PATCH 2/5] use const url in issue card page --- src/pages/workspace/card/WorkspaceCardVBANoECardView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pages/workspace/card/WorkspaceCardVBANoECardView.js b/src/pages/workspace/card/WorkspaceCardVBANoECardView.js index 78f768e38bf8..54608105af48 100644 --- a/src/pages/workspace/card/WorkspaceCardVBANoECardView.js +++ b/src/pages/workspace/card/WorkspaceCardVBANoECardView.js @@ -12,6 +12,7 @@ import * as Link from '../../../libs/actions/Link'; import * as User from '../../../libs/actions/User'; import ONYXKEYS from '../../../ONYXKEYS'; import compose from '../../../libs/compose'; +import CONST from '../../../CONST'; const propTypes = { ...withLocalizePropTypes, @@ -27,7 +28,7 @@ const WorkspaceCardVBANoECardView = props => ( title: props.translate('workspace.card.addWorkEmail'), onPress: () => { Navigation.dismissModal(); - Link.openOldDotLink('settings?param={"section":"account","openModal":"secondaryLogin"}'); + Link.openOldDotLink(CONST.ADD_SECONDARY_LOGIN_URL); User.subscribeToExpensifyCardUpdates(); }, icon: Expensicons.Mail, From b0bc47133dad89d9bce8de88619b147bddf9bda4 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 25 Nov 2021 10:28:08 -0700 Subject: [PATCH 3/5] use const url in connect bank account page --- src/pages/ReimbursementAccount/EnableStep.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pages/ReimbursementAccount/EnableStep.js b/src/pages/ReimbursementAccount/EnableStep.js index ee78c8fed403..a5b0b04fe75a 100644 --- a/src/pages/ReimbursementAccount/EnableStep.js +++ b/src/pages/ReimbursementAccount/EnableStep.js @@ -23,6 +23,7 @@ import * as Illustrations from '../../components/Icon/Illustrations'; import * as BankAccounts from '../../libs/actions/BankAccounts'; import * as Link from '../../libs/actions/Link'; import * as User from '../../libs/actions/User'; +import CONST from '../../CONST'; const propTypes = { /** Are we loading payment methods? */ @@ -76,7 +77,7 @@ class EnableStep extends React.Component { title: this.props.translate('workspace.bankAccount.addWorkEmail'), icon: Expensicons.Mail, onPress: () => { - Link.openOldDotLink('settings?param={"section":"account","openModal":"secondaryLogin"}'); + Link.openOldDotLink(CONST.ADD_SECONDARY_LOGIN_URL); User.subscribeToExpensifyCardUpdates(); }, shouldShowRightIcon: true, From eb927a167afbfef93e2ce1179774a98fb2fb2b21 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 25 Nov 2021 11:13:30 -0700 Subject: [PATCH 4/5] use encodeURIComponent --- src/CONST.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CONST.js b/src/CONST.js index 71d77776ccc5..117fb76e84d2 100755 --- a/src/CONST.js +++ b/src/CONST.js @@ -179,7 +179,7 @@ const CONST = { PRIVACY_URL: 'https://use.expensify.com/privacy', LICENSES_URL: 'https://use.expensify.com/licenses', PLAY_STORE_URL: 'https://play.google.com/store/apps/details?id=com.expensify.chat&hl=en', - ADD_SECONDARY_LOGIN_URL: 'settings?param=%7B%22section%22:%22account%22,%22openModal%22:%22secondaryLogin%22%7D', + ADD_SECONDARY_LOGIN_URL: `settings?param=${encodeURIComponent('{"section":"account","openModal":"secondaryLogin"}')}`, MANAGE_CARDS_URL: 'domain_companycards', FEES_URL: 'https://use.expensify.com/fees', CFPB_PREPAID_URL: 'https://cfpb.gov/prepaid', From 57ad08b349cddeb7c264f73fbda469b67909651c Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 25 Nov 2021 11:30:51 -0700 Subject: [PATCH 5/5] user encodeURI --- src/CONST.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CONST.js b/src/CONST.js index 117fb76e84d2..cd1c14e10091 100755 --- a/src/CONST.js +++ b/src/CONST.js @@ -179,7 +179,7 @@ const CONST = { PRIVACY_URL: 'https://use.expensify.com/privacy', LICENSES_URL: 'https://use.expensify.com/licenses', PLAY_STORE_URL: 'https://play.google.com/store/apps/details?id=com.expensify.chat&hl=en', - ADD_SECONDARY_LOGIN_URL: `settings?param=${encodeURIComponent('{"section":"account","openModal":"secondaryLogin"}')}`, + ADD_SECONDARY_LOGIN_URL: encodeURI('settings?param={"section":"account","openModal":"secondaryLogin"}'), MANAGE_CARDS_URL: 'domain_companycards', FEES_URL: 'https://use.expensify.com/fees', CFPB_PREPAID_URL: 'https://cfpb.gov/prepaid',