From 7d343b2ed8db96528244d24cd2c925315c9fcbcd Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Fri, 23 Aug 2024 10:05:16 -0400 Subject: [PATCH 1/2] Add CombinedCreateExpense beta to permissions --- src/CONST.ts | 1 + src/libs/Permissions.ts | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/src/CONST.ts b/src/CONST.ts index 53c19b3f299e..b8f2c0d31cf9 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -384,6 +384,7 @@ const CONST = { WORKSPACE_FEEDS: 'workspaceFeeds', NETSUITE_USA_TAX: 'netsuiteUsaTax', WORKSPACE_RULES: 'workspaceRules', + COMBINED_CREATE_EXPENSE: 'combinedCreateExpense', }, BUTTON_STATES: { DEFAULT: 'default', diff --git a/src/libs/Permissions.ts b/src/libs/Permissions.ts index 0a6756034f7d..2ff7c48a5e7c 100644 --- a/src/libs/Permissions.ts +++ b/src/libs/Permissions.ts @@ -40,6 +40,11 @@ function canUseWorkspaceRules(betas: OnyxEntry): boolean { return !!betas?.includes(CONST.BETAS.WORKSPACE_RULES) || canUseAllBetas(betas); } +function canUseCombinedCreateExpense(betas: OnyxEntry): boolean { + // We don't need to show this to all betas. + return !!betas?.includes(CONST.BETAS.COMBINED_CREATE_EXPENSE); +} + /** * Link previews are temporarily disabled. */ @@ -57,4 +62,5 @@ export default { canUseWorkspaceFeeds, canUseNetSuiteUSATax, canUseWorkspaceRules, + canUseCombinedCreateExpense, }; From 1d48409ed5e706da86feb68b40448658b9159392 Mon Sep 17 00:00:00 2001 From: Georgia Monahan Date: Fri, 23 Aug 2024 14:59:32 -0400 Subject: [PATCH 2/2] Rename to combinedTrackSubmit --- src/CONST.ts | 2 +- src/libs/Permissions.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/CONST.ts b/src/CONST.ts index b8f2c0d31cf9..24e1895920cf 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -384,7 +384,7 @@ const CONST = { WORKSPACE_FEEDS: 'workspaceFeeds', NETSUITE_USA_TAX: 'netsuiteUsaTax', WORKSPACE_RULES: 'workspaceRules', - COMBINED_CREATE_EXPENSE: 'combinedCreateExpense', + COMBINED_TRACK_SUBMIT: 'combinedTrackSubmit', }, BUTTON_STATES: { DEFAULT: 'default', diff --git a/src/libs/Permissions.ts b/src/libs/Permissions.ts index 2ff7c48a5e7c..58bf57449362 100644 --- a/src/libs/Permissions.ts +++ b/src/libs/Permissions.ts @@ -40,9 +40,9 @@ function canUseWorkspaceRules(betas: OnyxEntry): boolean { return !!betas?.includes(CONST.BETAS.WORKSPACE_RULES) || canUseAllBetas(betas); } -function canUseCombinedCreateExpense(betas: OnyxEntry): boolean { - // We don't need to show this to all betas. - return !!betas?.includes(CONST.BETAS.COMBINED_CREATE_EXPENSE); +function canUseCombinedTrackSubmit(betas: OnyxEntry): boolean { + // We don't need to show this to all betas since this will be used for developing a feature for A/B testing. + return !!betas?.includes(CONST.BETAS.COMBINED_TRACK_SUBMIT); } /** @@ -62,5 +62,5 @@ export default { canUseWorkspaceFeeds, canUseNetSuiteUSATax, canUseWorkspaceRules, - canUseCombinedCreateExpense, + canUseCombinedTrackSubmit, };