From 66f6551a8d3ec9eb151b643faf50fbfa48ff4ad3 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 25 Jan 2024 14:22:48 +0800 Subject: [PATCH 1/2] dismiss modal before navigating to concierge --- src/libs/actions/Report.ts | 10 +++++++--- src/pages/ReimbursementAccount/ValidationStep.js | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 36ac445a78d4..fa75c9961fc7 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -1577,7 +1577,7 @@ function updateWriteCapabilityAndNavigate(report: Report, newValue: WriteCapabil * * @param ignoreConciergeReportID - Flag to ignore conciergeChatReportID during navigation. The default behavior is to not ignore. */ -function navigateToConciergeChat(ignoreConciergeReportID = false) { +function navigateToConciergeChat(ignoreConciergeReportID = false, shouldDismissModal = false) { // If conciergeChatReportID contains a concierge report ID, we navigate to the concierge chat using the stored report ID. // Otherwise, we would find the concierge chat and navigate to it. // Now, when user performs sign-out and a sign-in again, conciergeChatReportID may contain a stale value. @@ -1587,10 +1587,14 @@ function navigateToConciergeChat(ignoreConciergeReportID = false) { // we need to ensure that the server data has been successfully pulled Welcome.serverDataIsReadyPromise().then(() => { // If we don't have a chat with Concierge then create it - navigateToAndOpenReport([CONST.EMAIL.CONCIERGE], false); + navigateToAndOpenReport([CONST.EMAIL.CONCIERGE], shouldDismissModal); }); } else { - Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(conciergeChatReportID)); + if (shouldDismissModal) { + Navigation.dismissModal(conciergeChatReportID); + } else { + Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(conciergeChatReportID)); + } } } diff --git a/src/pages/ReimbursementAccount/ValidationStep.js b/src/pages/ReimbursementAccount/ValidationStep.js index f1dfc944a24c..ec2d7597685e 100644 --- a/src/pages/ReimbursementAccount/ValidationStep.js +++ b/src/pages/ReimbursementAccount/ValidationStep.js @@ -201,7 +201,7 @@ function ValidationStep({reimbursementAccount, translate, onBackButtonPress, acc {translate('validationStep.letsChatText')}