[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

VickyStash · 2023-10-16T09:11:42Z

Details

[No QA] [TS migration] Migrate 'App.js' lib to TypeScript

Fixed Issues

$ #24923
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

The updated file touches a lot of different functionality, so it makes sense to test the next flows and make sure it works as before:

1

Open the app and log in the account A. Make sure the UI (language, etc) looks as usual.
On another device, open the app and log in to account B. Send several messages from both accounts and make sure it works as expected.
Reload the app. Make sure the app looks as expected after reloading.

2

Open the app and log in.
Sidebar -> Settings -> Profile - make sure the timezone is shown correctly
Go back to Settings -> Workspaces -> New workspace - make sure the workspace is created and you navigated to it

3
Test redirect to the desktop app. To be able to test it in DEV, you can temporarily remove this condition CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV.

Launch the Desktop app, don't login
Launch the Web app. When logging in for the first time, you will be prompted to open the Desktop app -> open -> make sure the Desktop app is opened, and the right account is logged in.

Offline tests

QA Steps

Verify that no errors appear in the JS console

The updated file touches a lot of different functionality, so it makes sense to test the next flows and make sure it works as before:

1

Open the app and log in the account A. Make sure the UI (language, etc) looks as usual.
On another device, open the app and log in to account B. Send several messages from both accounts and make sure it works as expected.
Reload the app. Make sure the app looks as expected after reloading.

2

Open the app and log in.
Sidebar -> Settings -> Profile - make sure the timezone is shown correctly
Go back to Settings -> Workspaces -> New workspace - make sure the workspace is created and you navigated to it

3
Test redirect to the desktop app. To be able to test it in DEV, you can temporarily remove this condition CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV.

Launch the Desktop app, don't login
Launch the Web app. When logging in for the first time, you will be prompted to open the Desktop app -> open -> make sure the Desktop app is opened, and the right account is logged in.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web.mov

web.reload.mp4

MacOS: Desktop

desktop.mov

desktop.redirect.mov

kubabutkiewicz

LGTM

# Conflicts: # src/types/onyx/index.ts

src/libs/Browser/types.ts

blazejkustra

Added some smaller comments, lgtm

src/types/onyx/Response.ts

src/types/onyx/Session.ts

src/libs/actions/App.ts

melvin-bot · 2023-10-20T08:39:34Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/libs/Browser/index.web.ts # src/libs/actions/App.ts # src/types/onyx/index.ts

# Conflicts: # src/libs/actions/App.ts

VickyStash · 2023-11-03T06:47:10Z

@jjcoffee I guess this PR has run out of your radar, could you take a look at it?

jjcoffee · 2023-11-03T09:39:21Z

@VickyStash Ah missed this one, apologies! Added it to my list, will get to it as soon as I can!

jjcoffee · 2023-11-06T16:29:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2023-11-07_15.49.06.mp4

Android: mWeb Chrome

android-chrome-2023-11-07_15.56.30.mp4

iOS: Native

ios-native-2023-11-07_15.32.06.mp4

iOS: mWeb Safari

ios-safari-2023-11-07_15.28.20.mp4

MacOS: Chrome / Safari

mac-chrome-2023-11-07_15.02.25.mp4

MacOS: Desktop

mac-desktop-2023-11-07_15.19.17.mp4

mac-chrome-redirect-2023-11-07_15.18.15.mp4

src/libs/actions/App.ts

jjcoffee · 2023-11-06T16:52:00Z

@VickyStash Can you merge main, to see if the performance tests get kicked back into gear?

VickyStash · 2023-11-06T17:20:20Z

@jjcoffee Hm, performance tests are still failing. I will investigate it later. Sorry for the inconvenience!

VickyStash · 2023-11-06T17:43:23Z

@jjcoffee Locally, tests are passed, I'm going to do more investigations tomorrow

# Conflicts: # src/types/onyx/Response.ts # src/types/onyx/index.ts

VickyStash · 2023-11-07T07:39:16Z

@jjcoffee I've merged the main one more time, and performance tests look okay now.

jjcoffee · 2023-11-07T14:11:42Z

@VickyStash Nice, thanks! Small tweak for the third test:

Launch the Web app where you were logged in before

Can you change it to something like "when logging in for the first time"? I assumed it meant the redirect would happen from the login page, before logging in.

Also I'm getting a crash when testing on that step (this only happens when starting from logged out on the web app):

mac-chrome-redirect-2023-11-07_15.07.37.mp4

VickyStash · 2023-11-07T14:28:16Z

@jjcoffee I was able to reproduce the crash on the main branch as well...

jjcoffee

LGTM!

melvin-bot · 2023-11-07T15:05:22Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24923 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

neil-marcellini · 2023-11-08T18:16:49Z

Reviewing today

neil-marcellini

Two very small things, but good to go. Thank you.

neil-marcellini · 2023-11-08T18:57:04Z

src/libs/actions/App.ts

+
+type Locale = ValueOf<typeof CONST.LOCALES>;
+
+let currentUserAccountID: number | string;


NAB: Shouldn't this always be a number and default to null?

@neil-marcellini What do you think about making it to be just a number and default to 0. With null it will require some updates here, like:

[currentUserAccountID ?? '']: {

I don't think 0 is a good default because on my dev environment, and maybe for others, 0 is a special account with email __FAKE__. So I think null is a better default, or perhaps -1.

You can fix this in a follow up if you like, I'll just merge what we have for now.

src/libs/actions/App.ts

OSBotify · 2023-11-09T21:43:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-10T15:59:12Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:52:39Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T22:12:28Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:55:43Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 3 commits October 16, 2023 10:59

[TS migration] Migrate 'App.js' lib

9e5dbf3

Merge branch 'main' into ts-migration/app-lib

2d4e87c

Update typing after API file was migrated to TS

8b55df1

kubabutkiewicz approved these changes Oct 17, 2023

View reviewed changes

Merge branch 'main' into ts-migration/app-lib

89791d4

# Conflicts: # src/types/onyx/index.ts

barttom reviewed Oct 18, 2023

View reviewed changes

src/libs/Browser/types.ts Show resolved Hide resolved

blazejkustra approved these changes Oct 20, 2023

View reviewed changes

src/types/onyx/Response.ts Outdated Show resolved Hide resolved

src/types/onyx/Session.ts Outdated Show resolved Hide resolved

src/libs/actions/App.ts Outdated Show resolved Hide resolved

Minor code improvements

935c2df

VickyStash marked this pull request as ready for review October 20, 2023 08:39

VickyStash requested a review from a team as a code owner October 20, 2023 08:39

melvin-bot bot requested review from jjcoffee and removed request for a team October 20, 2023 08:39

VickyStash added 4 commits October 30, 2023 09:38

Merge branch 'main' into ts-migration/app-lib

aab400b

# Conflicts: # src/libs/Browser/index.web.ts # src/libs/actions/App.ts # src/types/onyx/index.ts

Run linter after merging main

103d4af

Fix ts error

25e9ec7

Merge branch 'main' into ts-migration/app-lib

b9c9bc1

# Conflicts: # src/libs/actions/App.ts

jjcoffee reviewed Nov 6, 2023

View reviewed changes

src/libs/actions/App.ts Outdated Show resolved Hide resolved

VickyStash added 2 commits November 6, 2023 17:55

Merge branch 'main' into ts-migration/app-lib

fd0b267

Remove extra optional chaining

f6ccc56

Merge branch 'main' into ts-migration/app-lib

32913c1

# Conflicts: # src/types/onyx/Response.ts # src/types/onyx/index.ts

Get rid of extra nullish coalescing operators

062d120

jjcoffee approved these changes Nov 7, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini November 7, 2023 15:05

neil-marcellini previously approved these changes Nov 8, 2023

View reviewed changes

Remove extra comment

6955074

VickyStash dismissed neil-marcellini’s stale review via 6955074 November 9, 2023 07:25

neil-marcellini approved these changes Nov 9, 2023

View reviewed changes

neil-marcellini merged commit a2d5128 into Expensify:main Nov 9, 2023

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

VickyStash mentioned this pull request Nov 13, 2023

[TS Migration] Update currentUserAccountID type #31270

Merged

47 tasks

melvin-bot bot mentioned this pull request Nov 14, 2023

[HOLD for payment 2023-11-27] [HOLD for payment 2023-11-21] [TS migration] Migrate 'App.js' lib to TypeScript #24923

Closed

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

VickyStash commented Oct 16, 2023 •

edited

Loading

kubabutkiewicz left a comment

blazejkustra left a comment

melvin-bot bot commented Oct 20, 2023

VickyStash commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

jjcoffee commented Nov 6, 2023 •

edited

Loading

jjcoffee commented Nov 6, 2023

VickyStash commented Nov 6, 2023 •

edited

Loading

VickyStash commented Nov 6, 2023

VickyStash commented Nov 7, 2023

jjcoffee commented Nov 7, 2023 •

edited

Loading

VickyStash commented Nov 7, 2023

jjcoffee left a comment

melvin-bot bot commented Nov 7, 2023

neil-marcellini commented Nov 8, 2023

neil-marcellini left a comment

neil-marcellini Nov 8, 2023

VickyStash Nov 9, 2023

neil-marcellini Nov 9, 2023

neil-marcellini Nov 9, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023


		type Locale = ValueOf<typeof CONST.LOCALES>;

		let currentUserAccountID: number \| string;

[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

[No QA] [TS migration] Migrate 'App.js' lib to TypeScript #29661

Conversation

VickyStash commented Oct 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kubabutkiewicz left a comment

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 20, 2023

VickyStash commented Nov 3, 2023

jjcoffee commented Nov 3, 2023

jjcoffee commented Nov 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Nov 6, 2023

VickyStash commented Nov 6, 2023 • edited Loading

VickyStash commented Nov 6, 2023

VickyStash commented Nov 7, 2023

jjcoffee commented Nov 7, 2023 • edited Loading

VickyStash commented Nov 7, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 7, 2023

neil-marcellini commented Nov 8, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Nov 8, 2023

Choose a reason for hiding this comment

VickyStash Nov 9, 2023

Choose a reason for hiding this comment

neil-marcellini Nov 9, 2023

Choose a reason for hiding this comment

neil-marcellini Nov 9, 2023

Choose a reason for hiding this comment

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

VickyStash commented Oct 16, 2023 •

edited

Loading

jjcoffee commented Nov 6, 2023 •

edited

Loading

VickyStash commented Nov 6, 2023 •

edited

Loading

jjcoffee commented Nov 7, 2023 •

edited

Loading