Update Lyft.md

[miljakljajic]

Updated with the completed instructions

Details

Fixed Issues

$
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn’t include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function’s arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn’t exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I’ve added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it’s using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don’t apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[melvin-bot]

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Beamanator]

@miljakljajic can you make these edits so the main article text shows correctly? 🙏

I can help at 10am tomorrow if you'd like!

[Beamanator]

@miljakljajic need any help getting this fixed up? 👍 Let me know!

[miljakljajic]

I have read the CLA Document and I hereby sign the CLA

[Beamanator]

LGTM!

[melvin-bot]

@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[Beamanator]

No emergency, this is a markdown file update 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1311.664 ms → 1483.707 ms (+172.043 ms, +13.1%) 🔴
App start runJsBundle	914.200 ms → 1027.844 ms (+113.644 ms, +12.4%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1311.664 ms Stdev: 63.935 ms (4.9%) Runs: 1161.6926140002906 1206.808459999971 1238.082817999646 1239.2436680002138 1254.2079790001735 1262.3256419999525 1267.4831109996885 1271.3648709999397 1276.4657460004091 1293.748015999794 1297.2235869998112 1302.2389639997855 1302.3708450002596 1304.3639169996604 1305.6793440002948 1307.9535659998655 1312.4666210003197 1329.1209519999102 1332.0393359996378 1340.5734860002995 1340.9368909997866 1344.396041999571 1346.2392149996012 1350.731080999598 1358.2692799996585 1371.424633000046 1419.8408270003274 1429.9202570002526 1471.0511590000242 Current Mean: 1483.707 ms Stdev: 42.956 ms (2.9%) Runs: 1414.4851660002023 1428.604629999958 1432.7341029997915 1434.3258170001209 1439.7416030000895 1443.9338309997693 1446.6168710002676 1447.8377409996465 1451.3795640002936 1452.2920009996742 1452.4060479998589 1454.8642619997263 1466.4327189996839 1470.5202869996428 1473.2329059997573 1476.138580000028 1483.1691950000823 1487.8681920003146 1490.8654530001804 1491.1808470003307 1494.5148769998923 1496.4187449999154 1498.1326470002532 1502.4135280000046 1518.31182599999 1522.5193509999663 1527.7697459999472 1530.3423250000924 1534.7733070002869 1545.2266830001026 1563.444566999562 1606.13908000011
App start runJsBundle	Baseline Mean: 914.200 ms Stdev: 51.696 ms (5.7%) Runs: 800 839 850 851 864 867 877 889 893 893 895 898 900 904 904 910 911 912 915 922 929 937 948 956 957 976 993 997 1015 1024 Current Mean: 1027.844 ms Stdev: 25.054 ms (2.4%) Runs: 983 985 990 992 994 1000 1006 1010 1010 1016 1018 1018 1018 1018 1020 1024 1029 1033 1035 1036 1041 1043 1044 1047 1050 1052 1058 1060 1060 1063 1065 1073

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	690.796 ms → 695.401 ms (+4.605 ms, +0.7%)
App start nativeLaunch	23.452 ms → 25.875 ms (+2.423 ms, +10.3%)
App start regularAppStart	0.020 ms → 0.019 ms (-0.001 ms, -7.2%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 690.796 ms Stdev: 41.862 ms (6.1%) Runs: 635.6542969997972 642.5074469996616 643.156413000077 650.8212489997968 651.1551109999418 652.9583740001544 654.3974609998986 659.7284349994734 660.3814289998263 661.5328779993579 664.3979900004342 664.9289150005206 665.8672699993476 667.7406419999897 669.2019450003281 669.5110680004582 670.1845300002024 674.0964360004291 690.0360930003226 691.0863859998062 691.3890789998695 693.8940439997241 712.4460450001061 717.7700199997053 724.4090989995748 725.4714760007337 727.525717000477 737.0839440003037 746.155965000391 746.52209499944 752.8865970000625 777.318400000222 804.0662850001827 Current Mean: 695.401 ms Stdev: 24.166 ms (3.5%) Runs: 656.5508630005643 658.3015550002456 659.2021899996325 668.7571209995076 673.1403810000047 673.7608650000766 676.4779059998691 676.8595789996907 676.9453530004248 677.0260419994593 681.0381680000573 682.8919679997489 684.3190919999033 686.4068200001493 688.7556159999222 690.5574549995363 691.3173839999363 695.7466640006751 701.5880939997733 702.1040039993823 706.0099690007046 707.0690919999033 709.8478190004826 710.3542889999226 713.8984380001202 717.5015059998259 719.5493169995025 721.4130450002849 722.0926519995555 726.5349119994789 730.6417240006849 766.175578000024
App start nativeLaunch	Baseline Mean: 23.452 ms Stdev: 2.353 ms (10.0%) Runs: 21 21 21 21 21 21 21 21 21 21 22 22 22 22 23 23 24 24 24 24 25 25 25 25 25 25 26 26 27 29 29 Current Mean: 25.875 ms Stdev: 2.987 ms (11.5%) Runs: 21 22 22 23 23 23 24 24 24 24 24 24 24 24 25 25 25 25 27 27 27 27 27 27 28 29 29 29 30 30 30 35
App start regularAppStart	Baseline Mean: 0.020 ms Stdev: 0.002 ms (10.3%) Runs: 0.016439000144600868 0.01696799974888563 0.017049000598490238 0.017455999739468098 0.017862999811768532 0.018148000352084637 0.018269999884068966 0.0185139998793602 0.01859499979764223 0.01879899948835373 0.019898000173270702 0.019938999786973 0.019938999786973 0.019979000091552734 0.020181999541819096 0.020223000086843967 0.020305000245571136 0.0204670000821352 0.0206300001591444 0.021240999922156334 0.021443000063300133 0.021484999917447567 0.021484999917447567 0.022053999826312065 0.022297999821603298 0.022299000062048435 0.022338999435305595 0.02233900036662817 0.0224609998986125 0.022989999502897263 0.023315999656915665 0.025553000159561634 Current Mean: 0.019 ms Stdev: 0.001 ms (3.3%) Runs: 0.017659000121057034 0.017903000116348267 0.017986000515520573 0.018066000193357468 0.01822999957948923 0.018391999416053295 0.01839200034737587 0.01855500042438507 0.018635999411344528 0.018675999715924263 0.018675999715924263 0.018676000647246838 0.0186769999563694 0.018717000260949135 0.018799000419676304 0.0188400000333786 0.018880000337958336 0.018919999711215496 0.018920999951660633 0.019042999483644962 0.019082999788224697 0.019084000028669834 0.019247000105679035 0.019247000105679035 0.019490000791847706 0.019491000100970268 0.019652999937534332 0.019856000319123268 0.02001900039613247 0.0204670000821352

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅