From 029f88cf2b508f0095a4d7e874ca7d739f50d355 Mon Sep 17 00:00:00 2001 From: Muhammad Azamuddin Date: Tue, 26 Sep 2023 11:53:54 +0700 Subject: [PATCH 1/3] fix: mark propTypes policy as optional and provides default value on `MoneyRequestHeader.js` and `MoneyReportHeader.js` --- src/components/MoneyReportHeader.js | 3 ++- src/components/MoneyRequestHeader.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/MoneyReportHeader.js b/src/components/MoneyReportHeader.js index 3ccd61d32961..4fb385341279 100644 --- a/src/components/MoneyReportHeader.js +++ b/src/components/MoneyReportHeader.js @@ -35,7 +35,7 @@ const propTypes = { /** The role of the current user in the policy */ role: PropTypes.string, - }).isRequired, + }), /** The chat report this report is linked to */ chatReport: reportPropTypes, @@ -57,6 +57,7 @@ const defaultProps = { session: { email: null, }, + policy: undefined, }; function MoneyReportHeader({session, personalDetails, policy, chatReport, report: moneyRequestReport, isSmallScreenWidth}) { diff --git a/src/components/MoneyRequestHeader.js b/src/components/MoneyRequestHeader.js index 7f1e58912128..7d90606cd210 100644 --- a/src/components/MoneyRequestHeader.js +++ b/src/components/MoneyRequestHeader.js @@ -29,7 +29,7 @@ const propTypes = { policy: PropTypes.shape({ /** Name of the policy */ name: PropTypes.string, - }).isRequired, + }), /** Personal details so we can get the ones for the report participants */ personalDetails: PropTypes.objectOf(participantPropTypes).isRequired, @@ -58,6 +58,7 @@ const defaultProps = { parentReport: {}, parentReportAction: {}, transaction: {}, + policy: undefined, }; function MoneyRequestHeader({session, parentReport, report, parentReportAction, transaction, policy, personalDetails}) { From 54af82fb14190dae3ad8931d3ba1da37fb154e22 Mon Sep 17 00:00:00 2001 From: Muhammad Azamuddin Date: Tue, 3 Oct 2023 00:37:47 +0000 Subject: [PATCH 2/3] Update src/components/MoneyReportHeader.js Using `{}` as default value for policy propTypes instead of `undefined` Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np> --- src/components/MoneyReportHeader.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MoneyReportHeader.js b/src/components/MoneyReportHeader.js index 4fb385341279..8110199bafd8 100644 --- a/src/components/MoneyReportHeader.js +++ b/src/components/MoneyReportHeader.js @@ -57,7 +57,7 @@ const defaultProps = { session: { email: null, }, - policy: undefined, + policy: {}, }; function MoneyReportHeader({session, personalDetails, policy, chatReport, report: moneyRequestReport, isSmallScreenWidth}) { From 9f73b671ddbce43a6586dd09ff012ba5a9349bcf Mon Sep 17 00:00:00 2001 From: Muhammad Azamuddin Date: Tue, 3 Oct 2023 00:38:01 +0000 Subject: [PATCH 3/3] Update src/components/MoneyRequestHeader.js Using `{}` as default value for policy propTypes instead of `undefined` Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np> --- src/components/MoneyRequestHeader.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MoneyRequestHeader.js b/src/components/MoneyRequestHeader.js index 7d90606cd210..6f444eff9b05 100644 --- a/src/components/MoneyRequestHeader.js +++ b/src/components/MoneyRequestHeader.js @@ -58,7 +58,7 @@ const defaultProps = { parentReport: {}, parentReportAction: {}, transaction: {}, - policy: undefined, + policy: {}, }; function MoneyRequestHeader({session, parentReport, report, parentReportAction, transaction, policy, personalDetails}) {