From 9bc9c3aa37d8aeae5f5625836af069dcc8a78d96 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Fri, 25 Aug 2023 12:32:48 -0600 Subject: [PATCH 1/2] change order of thumbnail logic --- src/libs/ReceiptUtils.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libs/ReceiptUtils.js b/src/libs/ReceiptUtils.js index c1c028073690..5612100946c4 100644 --- a/src/libs/ReceiptUtils.js +++ b/src/libs/ReceiptUtils.js @@ -38,18 +38,18 @@ function validateReceipt(file) { * @returns {Object} */ function getThumbnailAndImageURIs(path, filename) { + const isReceiptImage = Str.isImage(filename); + // For local files, we won't have a thumbnail yet - if (path.startsWith('blob:') || path.startsWith('file:')) { + if ((path.startsWith('blob:') || path.startsWith('file:')) && isReceiptImage) { return {thumbnail: null, image: path}; } - const {fileExtension} = FileUtils.splitExtensionFromFileName(filename); - const isReceiptImage = Str.isImage(filename); - if (isReceiptImage) { return {thumbnail: `${path}.1024.jpg`, image: path}; } + const {fileExtension} = FileUtils.splitExtensionFromFileName(filename); let image = ReceiptGeneric; if (fileExtension === CONST.IOU.FILE_TYPES.HTML) { image = ReceiptHTML; From 44f5a77cdf808fb0108ba7e1ef0b0d1904d5f517 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Fri, 25 Aug 2023 12:35:24 -0600 Subject: [PATCH 2/2] change conditional logic --- src/libs/ReceiptUtils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReceiptUtils.js b/src/libs/ReceiptUtils.js index 5612100946c4..f7a53227d8d7 100644 --- a/src/libs/ReceiptUtils.js +++ b/src/libs/ReceiptUtils.js @@ -41,7 +41,7 @@ function getThumbnailAndImageURIs(path, filename) { const isReceiptImage = Str.isImage(filename); // For local files, we won't have a thumbnail yet - if ((path.startsWith('blob:') || path.startsWith('file:')) && isReceiptImage) { + if (isReceiptImage && (path.startsWith('blob:') || path.startsWith('file:'))) { return {thumbnail: null, image: path}; }