Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD - #11768] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 #9734

Closed
mvtglobally opened this issue Jul 6, 2022 · 32 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2 Planning Changes still in the thought process

Comments

@mvtglobally
Copy link

mvtglobally commented Jul 6, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Decrease the width of your browser window to the point in which the chat view is not visible, only the LHN
  2. Click on the magnifying glass search icon in the LHN header
  3. Click on any chat from the search results and observe that you're navigated back to a view of the LHN and not the view of the chat you just clicked on

Expected Result:

When the screen width on Web/desktop has been decreased to the size of mobile/tablet, it should work in exactly the same way as those devices.

  1. Click on the search icon to navigate to the search page
  2. Click on any chat from the search results
  3. Navigate to the chat view
  4. Click the back caret < in the top left of the chat to return to the LHN

Actual Result:

The LHN is in view and not the chat

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.79-11
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-06-16.at.9.41.42.PM.mov

Upwork URL: https://www.upwork.com/jobs/~010e7681ab13edf3b1
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1655398548680369

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jul 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2022

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 6, 2022
@mvtglobally mvtglobally changed the title nable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Jul 6, 2022
@strepanier03
Copy link
Contributor

strepanier03 commented Jul 7, 2022

Triaging now.

Using Chrome browser and trying multiple different sizes I'm unable to recreate this behavior. Is this specific to a certain browser type @mvtglobally?

@adeel0202
Copy link
Contributor

@strepanier03, it is reproducible in chrome and safari both (I couldn't check on any other browser). It is also reproducible in the desktop app.

@strepanier03
Copy link
Contributor

Hmm, I'll send it on but I can't repro myself in Chrome or Firefox.

@strepanier03 strepanier03 removed their assignment Jul 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2022

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Gonals Gonals added Weekly KSv2 Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Jul 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 8, 2022
@Gonals
Copy link
Contributor

Gonals commented Jul 8, 2022

Good candidate for external!

@Gonals Gonals removed their assignment Jul 8, 2022
@trjExpensify
Copy link
Contributor

Ah yeah, I can repro this. I misread it initially, but yes.. accessing a chat from the Search page doesn't work. Job on upwork here: https://www.upwork.com/jobs/~010e7681ab13edf3b1

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 8, 2022
@trjExpensify
Copy link
Contributor

I caught up with Marc earlier and I'm going to pop the issue on [Hold] & Planning for the time being. We have plans to revisit react-navigation more holistically, so we should account for this issue then to avoid adding any additional workarounds or hacks atop of what is already complex code.

@trjExpensify trjExpensify changed the title [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 [Hold] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Aug 8, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2022
@trjExpensify
Copy link
Contributor

This is held, Melv.

@Santhosh-Sellavel
Copy link
Collaborator

on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2022
@Luke9389 Luke9389 changed the title [Hold] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Oct 14, 2022
@trjExpensify
Copy link
Contributor

^^ 👋 @Luke9389, has this come off hold or something?

@Luke9389
Copy link
Contributor

OH! huh. Weeeird. I coulda sworn someone commented that this was off hold.

My bad!

@Luke9389 Luke9389 changed the title [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 [HOLD] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Oct 18, 2022
@trjExpensify
Copy link
Contributor

Ha, all good!

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@trjExpensify trjExpensify changed the title [HOLD] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 [HOLD - Navigation] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Oct 31, 2022
@trjExpensify
Copy link
Contributor

Updated the title to be more specific that this is held on the Navigation initiative.

@JmillsExpensify JmillsExpensify changed the title [HOLD - Navigation] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 [HOLD - #11768] [$500] Unable to open chat through search when the browser/app size is decreased - reported by @adeel0202 Nov 3, 2022
@JmillsExpensify
Copy link

snagging this as I'm on the tracking issue.

@JmillsExpensify
Copy link

See the tracking issue for the latest.

@JmillsExpensify
Copy link

Still holding.

@JmillsExpensify
Copy link

Still held as this initiative goes through the design process.

@JmillsExpensify
Copy link

Still holding on the larger react navigation reboot.

@tgolen
Copy link
Contributor

tgolen commented Nov 30, 2022

Is this really a case that we should be supporting? I think we only care about "normally" sized browser windows and mobile web clients. My guess is that at these widths, there is quite a bit more broken than just this navigation issue, and so supporting this browser platform and window size should be regarded as a new feature and not a bug.

@JmillsExpensify
Copy link

That's a really great point. I think you're right – to the extent that this also fails the "supported platform" stipulation for bugs as well. I'm actually going to close as a result but anyone from Expensify on this issue can re-open if they feel strongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2 Planning Changes still in the thought process
Projects
None yet
Development

No branches or pull requests