[$1000] [HOLD for payment 2023-02-10] [Form Refactor] ACHContractStep

[luacmartins]

Coming from the New Expensify Forms design doc, we should refactor ACHContractStep to use the new form component, follow the guidelines below:

Here's an example of a Form refactor: #9056

Guidelines

1. Replace the form component with Form.js.
2. Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
3. Pass a validate callback prop.
4. Pass an onSubmit callback prop that calls the API via an action.
5. Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
6. Remove any unused code.

Testing

Verify that:

• UI looks as it did before the refactor
• Values can be added and edited
• Errors are highlighted correctly (input border)
• Error messages show up correctly
• Draft values are saved properly
• Form alerts are displayed correctly
• Clicking the fix the errors link focuses the first input with error
• No duplicate submission of the form occurs (when it's already submitting)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f33cb0c356b601a0
• Upwork Job ID: 1625948861270761472
• Last Price Increase: 2023-02-15

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mallenexpensify]

@luacmartins couple questions before posting the job on Upwork

1. The Design Doc linked isn't accessible to those outside of Expensify, will a contributor need any details from the doc in order to do this job?
2. Should we start at $250 like most other jobs?

[luacmartins]

Great questions @mallenexpensify!

The Design Doc linked isn't accessible to those outside of Expensify, will a contributor need any details from the doc in order to do this job?

The issue description should have everything the contributor needs to work on this.

Should we start at $250 like most other jobs?

Yes! Let's start at $250.

Thanks for the help!

[luacmartins]

This issue is being put on hold due to push to page discussions, as per this comment.

[mallenexpensify]

Bumped to weekly since it's on hold, let me know if/when the job should be posted @luacmartins

[melvin-bot]

This issue has not been updated in over 15 days. @mallenexpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[luacmartins]

@mallenexpensify this issue is no longer on hold!

[mallenexpensify]

Posted! https://www.upwork.com/jobs/~010b1678b6661417b0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.64-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Refactor] ACHContractStep #13501

If no regressions arise, payment will be issued on 2023-02-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A (internal)
• Contributor that fixed the issue - N/A (internal)
• Contributor+ that helped on the issue and/or PR - @mollfpr

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[grgia]

@JmillsExpensify do you know if @mollfpr has been paid for C+ review? If so, we can close this out

[mollfpr]

@grgia I haven't 😅

[JmillsExpensify]

Oh I'm not assigned to this issue. Should I assign myself and pay it?

[JmillsExpensify]

I'll go ahead and jump in given the above confirmation that this hasn't been processed.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f33cb0c356b601a0

[MelvinBot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[MelvinBot]

Current assignee @grgia is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

📣 @mollfpr You have been assigned to this job by @JmillsExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[JmillsExpensify]

@mollfpr Can you apply to the Upwork job above? We can get it kicked off.

[mollfpr]

@JmillsExpensify applied, thank you!

[JmillsExpensify]

Cool, offer sent.

[mollfpr]

@JmillsExpensify Accepted 👍

[JmillsExpensify]

Awesome, paid out. Closing this as well. Great work all!