[HOLD for payment 2023-03-20] [HOLD #12370][$2000] Audit forms and fix inconsistencies with focus, tab and shift + tab behavior 3/4

[dylanexpensify]

We should audit all our forms and fix any inconsistencies with focus, tab, shift + tab and enter behavior. The expected behavior is as follows:

1. Tab navigates to the next input.
2. Shift + tab navigates to the previous input.
3. Enter submits the form.
4. Space toggles checkboxes/dropdowns.

Note: We should make sure that tabbing cycles through the form in an order that makes sense, usually top to bottom.

Here's a list of forms to be audited:

• IOU flow
• KYC flow
• New Room screen
• Add Debit card flow
• New password form

[MelvinBot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Note: decision to split this main issue up into smaller issues came from this convo

[marcochavezf]

I've been working on an N7 issue these last few days and still today, but I will come back to this issue today at EOD or tomorrow morning.

[Christinadobrzyn]

@dylanexpensify can you clarify, are we paying the hired contributor $250 to update all of the forms in the OP? Also asked here

[marcochavezf]

Oh I hadn't seen the conversation. I think this case I can just unassign myself since the Exported label will be applied to assign reviewers.

[Christinadobrzyn]

Dylan confirmed this GH job is $250. Created Upwork job

Internal job posting - https://www.upwork.com/ab/applicants/1499638878787203072/job-details
External job positing - https://www.upwork.com/jobs/~014a2b9d0ae263c283

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[MelvinBot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mdneyazahmad]

Proposal

These 4 related issues are very similar. I proposed the solution here #7918 (comment)

[thienlnam]

Still waiting on a volunteer to audit the forms

[Christinadobrzyn]

Price increase to $500

[luacmartins]

I agree. That's within the audit scope.

[mdneyazahmad]

I am sorry for being late here. I was ooo. @Santhosh-Sellavel I have drafted the PR. I need some help with the test in native device and desktop. How can we open the url in those platforms?

[Santhosh-Sellavel]

Remove the checks on this file which excludes deep-linking for dev environment that should work, after that you can open the link!

[mdneyazahmad]

@Santhosh-Sellavel I have marked that PR ready for review, and posted in slack channel for help here about opening the url in desktop and native devices.

[MelvinBot]

📣 @mdneyazahmad! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent redirecting to / on form submit #15240

If no regressions arise, payment will be issued on 2023-03-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @thienlnam] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dylanexpensify] Determine if we should create a regression test for the bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@dylanexpensify] Review the proposed regression test steps and location.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

I think we don't need a BZ Checklist. It's all N/A for this one!

@dylanexpensify

cc: @thienlnam

[dylanexpensify]

@thienlnam can you confirm payout amounts of $2000? As well, is there a time bonus here?

[thienlnam]

Looks correct, and I believe this issue was created way back before we even added time bonuses so let's just do normal payouts for this issue

[dylanexpensify]

@Santhosh-Sellavel @mdneyazahmad please apply here!

[mdneyazahmad]

@dylanexpensify applied

[Santhosh-Sellavel]

Done, thanks!

[dylanexpensify]

Had to run last Friday for emergency appts, so will get payments out now! Sorry for delay!

[dylanexpensify]

offers sent!

[Santhosh-Sellavel]

Accepted thanks @dylanexpensify!

[dylanexpensify]

Alright, we're all sorted here! Thanks for playing!