Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor uses of Text, Button, and TextInput #6585

Closed
puneetlath opened this issue Dec 3, 2021 · 1 comment
Closed

Refactor uses of Text, Button, and TextInput #6585

puneetlath opened this issue Dec 3, 2021 · 1 comment
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

This is a follow up to #3133 and #6583 in which we renamed our custom Text and Button components to ExpensifyText and ExpensifyButton and added a rule to our ESLint configuration that throws an error if Text, Button or TextInput are imported from react-native.

We prefer for our custom components to be used rather than the default react native Text, Button or TextInput components, because they are built with our style/specifications already. However we have ~15 cases in our code currently where the react native components are used.

Some of those cases are in the custom components themselves, which are built atop the react native components. But we also have some cases where the react native components are being used in other components. We should see if those can be refactored to use our components instead.

@MelvinBot
Copy link

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants