Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Attachment - No magnifying glass seen when hoovered over image in chat #6075

Closed
mvtglobally opened this issue Oct 27, 2021 · 9 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@mvtglobally
Copy link

mvtglobally commented Oct 27, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Upload an image in chat
  2. Select image that was uploaded
  3. Hoover mouse over selected image to see magnifying glass

Expected Result:

Magnifying glass would be visible when hovering over image

Actual Result:

No magnifying glass

Workaround:

n/a

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

**Version Number:v1.1.10-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Video

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Oct 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 27, 2021
@mvtglobally mvtglobally changed the title [Chat] Web - Attachment - No magnifying glass seen when hoovered over image in chat Web - Attachment - No magnifying glass seen when hoovered over image in chat Oct 27, 2021
@CortneyOfstad CortneyOfstad removed their assignment Oct 27, 2021
@CortneyOfstad CortneyOfstad added the Improvement Item broken or needs improvement. label Oct 27, 2021
@aldo-expensify
Copy link
Contributor

Is this referring to showing the cursor once we open the image? like this:

image

or does it refer to the cursor in this instance?
image

I can see the magnifying glass cursor when we are in the process of uploading too:
image

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Nov 1, 2021

Hey @mvtglobally , can you help me reproduce this bug? Does the step (1) include clicking the "Send" button? When you say "Select image that was uploaded", are you referring to clicking on its thumbnail on the chat?, thanks! :)

@MelvinBot MelvinBot removed the Overdue label Nov 1, 2021
@mvtglobally
Copy link
Author

@aldo-expensify Yes. You need to send the image to another user first.

@mvtglobally
Copy link
Author

Issue reproducible during KI retests.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Nov 2, 2021

@aldo-expensify Yes. You need to send the image to another user first.

Thanks, so... are we missing the magnifying glass on the thumbnail image?

image

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Nov 2, 2021

I'm not 100% convinced about that the cursor over the thumbnail should be a magnifying glass. It makes sense to me once the image is "opened" and clicking it zooms in, but here you are not exactly just zooming in, you are opening a modal with the image which has a download button.

Where does the information for the "Expected result" come from? Is it written in some specification?

For example, in Whatsapp, it works exactly like that. You get the hand (pointer?) cursor when hovering the thumbnail and you get the magnifying glass after you open it.

@aldo-expensify
Copy link
Contributor

I'm closing this as I don't see it as a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants