Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #3855]1Password - user is prompted to enter the master password 2 times (for email and password) #5956

Closed
isagoico opened this issue Oct 20, 2021 · 9 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Have 1Password installed and enabled as your autofill primary option in your device
  2. Open New Expensify
  3. Tap on the email input and select the 1Password option
  4. Select an account and continue
  5. On the Password field selected the 1Password option

Expected Result:

User should be prompted for the account email/password only one time on email field.

Actual Result:

User is prompted to enter the master password twice.

Workaround:

None needed, user can proceed as is.

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2021-10-19.at.8.29.17.PM.mp4

Expensify/Expensify Issue URL:

Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634571339413900

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

May be resolved in #5275.

@Jag96
Copy link
Contributor

Jag96 commented Oct 20, 2021

After testing #5275 on my physical iPhone it looks like the issue still exists, but let's put this on hold until after #5275 is finished to prevent conflicts and to confirm the finished PR doesn't fix this.

@Jag96 Jag96 changed the title 1Password - user is prompted to enter the master password 2 times (for email and password) [HOLD #3855]1Password - user is prompted to enter the master password 2 times (for email and password) Oct 20, 2021
@Jag96 Jag96 added Weekly KSv2 and removed Daily KSv2 labels Oct 20, 2021
@Jag96
Copy link
Contributor

Jag96 commented Oct 28, 2021

Still on hold until #5275 is merged

@Jag96
Copy link
Contributor

Jag96 commented Nov 4, 2021

Same, still on hold

@Jag96
Copy link
Contributor

Jag96 commented Nov 11, 2021

Related PR is in review, this is still on hold

@Jag96
Copy link
Contributor

Jag96 commented Nov 22, 2021

Same, PR still in review

@MelvinBot MelvinBot removed the Overdue label Nov 22, 2021
@Jag96
Copy link
Contributor

Jag96 commented Nov 30, 2021

PR still in review

@Jag96 Jag96 added the Reviewing Has a PR in review label Nov 30, 2021
@Jag96
Copy link
Contributor

Jag96 commented Nov 30, 2021

This will be fixed by #5275, closing this one

@Jag96 Jag96 closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants